update install and dune dependency in package overview #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabine
reviewed
Aug 27, 2024
| @@ -54,14 +54,14 @@ in | |||
| Install | |||
| </h2> | |||
|
|
|||
| <%s! Copy_to_clipboard.small_code_snippet ~id:"install-package" ~class_:"whitespace-nowrap" ("opam install " ^ package.name ^ "." ^ specific_version) %> | |||
| <%s! Copy_to_clipboard.small_code_snippet ~id:"install-package" ~class_:"whitespace-nowrap" ("opam install " ^ package.name) %> | |||
There was a problem hiding this comment.
removing the version entirely only makes sense when we are on the latest version of the package, i.e. on any URL like this: https://ocaml.org/p/PACKAGE_NAME/latest.
Also, I think we don't need to remove the version from the opam install command because being precise here is actually helpful so people get an error message if they haven't updated their opam.
There was a problem hiding this comment.
It should now be omitted for only the dune dependency for latest version of the package. Am i correct?
There was a problem hiding this comment.
I don't know, there's no new commit on this branch yet.
sabine
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2015
cc @sabine