Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Academic Page Redesign #2694

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

oyenuga17
Copy link
Contributor

@sabine please help put on staging 🙏

@cuihtlauac
Copy link
Collaborator

Something strange is taking place with this PR.

CI attempts to build commit 7be9c34 (see Checks / Build and test (ubuntu-latest) / Checkout Repo / Fetching the repository). Under that commit, I see the same issue as in the checks.

However, doing gh pr checkout 2694 switches to commit 8fcd29a (which is the latest pushed on the PR commits lists). There, the compilation has no errors.

@cuihtlauac
Copy link
Collaborator

cuihtlauac commented Sep 13, 2024

I better understand what's going on. Check the "Checkout Repo" part of the CI build log. Line 73 says:

HEAD is now at 72e1a29 Merge f277dd95d9e2c1210e2c2c95a4399163eba4acd4 into 39a5d167292a6fdcc1a6644ec10808e4f5eeec96

f277dd9: this is the latest commit of your branch
39a5d16: this main right after merging PR #2698

You can reproduce the CI build error by doing this:

git checkout -b merge-2694 39a5d167292a6fdcc1a6644ec10808e4f5eeec96
git merge f277dd95d9e2c1210e2c2c95a4399163eba4acd4
make build

There's a sync issue between your branch and main. Doing git rebase main in your branch also allows to reproduce the build failure

@oyenuga17
Copy link
Contributor Author

@cuihtlauac thanks for pointing this out. I'll make the necessary update 👍

sabine added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants