Skip to content

Conversation

@whitequark
Copy link
Member

@whitequark whitequark commented Feb 28, 2017

No description provided.

OASIS has been accidentally broken in the past.
@gasche
Copy link
Member

gasche commented Feb 28, 2017

While we are at it, could we have an ocb_stubblr-using dependency? It would make sense to have one dependency for all non-trivial ocamlbuild plugins out there: cppo also comes to mind; there is also the namespace-as-ocamlbuild plugin, but I don't know if it is used in opam-released packages, and Solvuu (again, not sure).

These haven't been broken in the past, and let's keep it this way.
@whitequark
Copy link
Member Author

While we are at it, could we have an ocb_stubblr-using dependency? It would make sense to have one dependency for all non-trivial ocamlbuild plugins out there: cppo also comes to mind

Added both.

Solvuu (again, not sure).

The dependencies seem quite heavy (they all need core_kernel...)

@whitequark whitequark changed the title Also build a package using OASIS on CI Test more downstream code on CI Feb 28, 2017
@gasche
Copy link
Member

gasche commented Feb 28, 2017

Ok, this sounds like a nice compromise. Feel free to merge once we get CI results or whenever.

@gasche
Copy link
Member

gasche commented Feb 28, 2017

(Are you the kind of person that prefer other people to merge their PRs, or to have a chance to do a last amending round before merging themselves?)

@whitequark
Copy link
Member Author

(Are you the kind of person that prefer other people to merge their PRs, or to have a chance to do a last amending round before merging themselves?)

It does not matter to me very much. Unless explicitly noted my PR commit stacks are always ready to merge; I rebase before every push.

@whitequark whitequark merged commit 11b04c9 into ocaml:master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants