Skip to content

Conversation

@hhugo
Copy link
Collaborator

@hhugo hhugo commented Jun 20, 2024

on top of #334 #344

@hhugo hhugo requested a review from gasche June 20, 2024 23:38
@hhugo hhugo changed the title Update change Update changelog Jun 20, 2024
@hhugo hhugo force-pushed the changelog branch 3 times, most recently from 5c507ab to 58c9abe Compare June 24, 2024 14:37
@hhugo
Copy link
Collaborator Author

hhugo commented Jun 24, 2024

We can release ocamlbuild after this PR is merged and close #322

@hhugo
Copy link
Collaborator Author

hhugo commented Jun 24, 2024

This is ready for review

@gasche
Copy link
Member

gasche commented Jun 24, 2024

My understanding is that you ( @hhugo ) have integrated most of the patches from the fdopen repository, and that we believe that the remaining one are not necessary anymore for ocamlbuild to work correctly on Windows. Thanks! Splitting them up, discussing them together and cleaning them up when possible was the right move, I think, and I'm glad I could help from the sidelines.

Do you have an idea of which of the several Windows configurations are known to work correctly for ocamlbuild now? (Do we expect ocamlbuild to work well with or without cygwin? does msvc-or-mingw play any role?)

@hhugo
Copy link
Collaborator Author

hhugo commented Jun 24, 2024

Do you have an idea of which of the several Windows configurations are known to work correctly for ocamlbuild now? (Do we expect ocamlbuild to work well with or without cygwin? does msvc-or-mingw play any role?)

What work is what we have in the CI. That is native windows with mingw. I would expect the msys2 setup to work as well (based on the [comment](#339 (comment) from @dra27)

For the cygwin variant, my understanding is that one must use the fdopen repo which is full of patches making it hard to reason about things. What does that mean to be working in that setup ? What set of opam-repo to use ?
I could try to bring back some CI jobs for this setup. Is it still possible with setup-ocaml.3 ?

For the msvc port, I've no idea what to expect. @dra27 can you help here ? is opam supposed to work out of the box in that setup ?

@gasche gasche merged commit 04041b9 into master Jun 25, 2024
@gasche
Copy link
Member

gasche commented Jun 25, 2024

Thanks for the clarifications!

Note that I am not myself asking for any particular configuration to work, I was just wondering what the current status is.

@hhugo hhugo deleted the changelog branch June 25, 2024 07:43
@hhugo
Copy link
Collaborator Author

hhugo commented Jun 25, 2024

#347 demonstrate that msvc is working.
So we have:

  • mingw ok
  • msvc ok
  • cygwin untested, setup-ocaml doesn't support this setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants