Add macos to the CI #349
Merged
Add macos to the CI #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using non existant path
gasche
reviewed
Jun 27, 2024
ld complain/warn about inexistant directory in search path https://github.com/ocaml/ocamlbuild/actions/runs/9678830233/job/26703462729 |
|
@kit-ty-kate you probably encountered this issue when you dealt with the new-install-directories transition. (Apparently in the code we decided to unconditionally use the new layout.) Could you by chance confirm that the conditional logic proposed by @hhugo is the best approach? |
|
Oh, I hadn't realized this and maybe we should have been more careful in #328, but the combined diff makes sense. |
gasche
reviewed
Jun 27, 2024
gasche
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.