Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'.' path triggers an unhandled exception on Windows #64

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

db4
Copy link
Contributor

@db4 db4 commented May 25, 2023

I submitted this PR several years ago (to the Gitlab repo), but the bug is still there. So another attempt.

@hhugo
Copy link
Contributor

hhugo commented Jul 30, 2024

@gerdstolpmann, any reason not to merge this PR ?

ejgallego added a commit to ejgallego/ocamlfind that referenced this pull request Sep 3, 2024
@ejgallego
Copy link
Contributor

I confirm this PR fixes ocaml/opam#6129

Copy link

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original logic was clearly buggy. LGTM

@gerdstolpmann gerdstolpmann merged commit 848db20 into ocaml:master Sep 9, 2024
@JasonGross JasonGross mentioned this pull request Sep 10, 2024
tahina-pro added a commit to project-everest/everest that referenced this pull request Dec 9, 2024
With the default ocamlfind, on Windows, we encounter
ocaml/opam#6129, which should have been fixed by
ocaml/ocamlfind#64, but that PR had not been merged
until that release (see also
ocaml/opam-repository#26510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants