Reference to constructor in module

[Julow]

With the new model, the reference M.Foo doesn't resolve but M.t.Foo does.

module M : sig
  type t = Foo
end

(** {!constructor:M.Foo} {!constructor:M.t.Foo} *)

In Paths_types, constructor parent should be parent or a new constructor_parent instead of datatype.

Also, the type for references allows extension and exception constructors in {!constructor:..} references but won't resolve them.

[jonludlam]

Hmm, if we changed the identifier we wouldn't be able to link correctly as we wouldn't know which type the construct was in. I think the issue is probably that when we open the module containing the type declaration in Env.open_signature we should recurse into the type declarations at that point and add them to the env?

[Julow]

Constructors (and fields) are already added to the env (in Env.add_type). It should be easy to add the corresponding TypeDecl to constructors in the env (add a third argument to Constructor in Component.Element).

The current issue is in signatures (Find) and Paths_types.

[jonludlam]

I'm still not clear on what the issue is with Paths_types?

[Julow]

We just need to allow "signature | datatype" parents in constructor references.

[jonludlam]

Oh in the references! I was thinking of the identifiers :-)

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. The main purpose of this is to keep the issue tracker focused to what is actively being worked on, so that the amount and variety of open yet inactive issues does not overwhelm contributors.

An issue closed as stale is not rejected — further discussion is welcome in its closed state, and it can be resurrected at any time. odoc maintainers regularly check issues that were closed as stale in the past, to see if the time is right to reopen and work on them again. PRs addressing issues closed as stale are as welcome as PRs for open issues. They will be given the same review attention, and any other help.

[Julow]

This is in the next milestone.