-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove odoc_html_support_files.ml #1044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this was to avoid having ocaml-crunch
as a build-dependency instead of a test-dependency.
I'm in favor of this change as it adds few dependencies and remove a often conflicting file.
@@ -5,34 +5,32 @@ | |||
(aliases runtest support-files) | |||
(enabled_if | |||
(> %{ocaml_version} 4.08)) | |||
(target odoc_html_support_files.ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
odoc.opam is not uptodate as crunch
is still listed with-test
. It would be nice to test various versions of crunch and find an eventual lower bound.
This requires a change entry as well as an approval from more than one person. |
@jonludlam As you implemented the ocaml-crunch rule, what do you think of merging this ? |
I'm agnostic in this debate (which has... a conflict with Counting the recursive one, this PR adds the following dependencies:
which I think is reasonable, although the benefit is not essential. It can easily be revert if needed. |
Since we're already having to do some work on release branches (ie, substituting in the version in the crunched files and then updating the generated ml file), we could just as well do the crunching and remove the dependency, if we felt it that important. |
It seems that there's 3 approvals. This just need a rebase and I'd merge. |
A rebase and adding the dependency. |
b6d9610
to
6d34ae0
Compare
Thanks! |
This PR removes the need to promote odoc_html_support_files.ml from the source tree.
It is still present in the build.
I am aware that I might have missed something that make this a bad idea, but I wanted to open that discussion.