Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Tree and Forest modules for sidebars and index #1228

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Oct 30, 2024

Reduce diff of #1220

Probably more could be put in this branch but my goal is to split #1220 as much as possible to make the diff digestable.

cc @panglesd for review (I don't have the repo rights to add reviewers anymore)

Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, this is cleaner and atomic.

I left minor comments and a more important compat issue. Once this one is resolved, it can be merged!

src/utils/tree.ml Show resolved Hide resolved
src/utils/tree.ml Show resolved Hide resolved
src/utils/tree.mli Show resolved Hide resolved
@panglesd panglesd added the no changelog This pull request does not need a changelog entry label Oct 31, 2024
@jonludlam
Copy link
Member

Thanks!

@jonludlam jonludlam merged commit 2de9dfc into ocaml:master Oct 31, 2024
13 checks passed
@gpetiot gpetiot deleted the trees branch October 31, 2024 12:07
panglesd added a commit to panglesd/sherlodoc that referenced this pull request Dec 9, 2024
Several changes:
- Entries are now defined in the `odoc_index` library,
- Entries can have new kinds (pages, source, ...)
- Indexes have the form of "skeletons of entries", that can be folded.
- Indexes can be created by odoc with the `odoc compile-index` command, and
  then consumed by sherlodoc.

These changes come from:
- ocaml/odoc#1228
- ocaml/odoc#1232
- ocaml/odoc#1233
- ocaml/odoc#1244
- ocaml/odoc#1250
- ocaml/odoc#1251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants