-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform treatment of sidebar #1251
Merged
Merged
Changes from 56 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
5acab30
WIP
panglesd a3e3aad
WIP 2
panglesd 0f9ae22
small improvements
panglesd 99abfa2
Rename file
panglesd 6f5cd16
Create a separate module for intermediate index
panglesd d743543
Allow to order modules
panglesd 4f0b909
Sidebar: Use a better name when no zero title are there
panglesd 416b465
Remove resolver logic to return all pages
panglesd 7f23b64
Keep `--root` groups
panglesd 7294fc4
Use computed index to compute json
panglesd db9afcb
Fix adding container pages in indexes
panglesd 0a0f1d7
Index: handle roots even when they are included in each others
panglesd b5075a6
Sidebar: rendering improvements
panglesd b42e114
Driver: Use a sidebar root for pages, and one per library
panglesd 1bafc35
Add a `@toc_status` tag
panglesd 3cc15c1
Index: Comments on `--root`
panglesd 59290d0
promote tests
panglesd 70030f5
Remove the link from content
panglesd 46b0e32
Index: Ignore items enclosed in stop comments
panglesd c8a267f
Revert "Driver: Use a sidebar root for pages, and one per library"
panglesd f090f82
Index: Add implementations to the index
panglesd 67210a0
promote test to fixup
panglesd 71278bf
Sidebar: Actually add implementations to the sidebar
panglesd 8c33344
Driver: Add a `src/` landing page
panglesd 068a856
Compatibility
panglesd e99b74c
CSS: slightly restyle the global sidebar
panglesd 41d7509
Compatibility
panglesd 3c8ddaf
Sidebar: Add the global sidebar to implementation pages
panglesd 447be65
Driver: remove LICENSE and other file in non voodoo mode
panglesd 9aa24dc
Sidebar: Use short title if present
panglesd bf57d95
Breadcrumbs: use sidebar index if possible
panglesd f066756
Breadcrumbs: keep original behavior when no sidebar is given
panglesd 9f32283
Breacrumbs: simplify logic
panglesd 4de674b
Sidebar: sort by kind first
panglesd bade68d
Sidebar: better default order
panglesd 6f4a550
Driver: don't include source dir if no implementation are rendered
panglesd 871fbef
Compatibility
panglesd a4382f7
Json index: use json printing function
panglesd 7277424
Delete useless `Html.Utils` module
panglesd 29c81de
Format dune files
panglesd 6e823d0
Breadcrumbs: fix order
panglesd b329862
Sidebar: Add a `hidden` value for `toc_status`.
panglesd 42d3e37
Sidebar: Add `order_category` to help ordering the unordered pages
panglesd 03acc3b
Promote tests
panglesd 604872f
Add a `--escape-breadcrumbs` option to add a 🏠 to breadcrumbs
panglesd 056e9d9
Fix breadcrumbs with leaf index pages
panglesd 0d38470
Doc compute landing pages for not selected packages
panglesd cad19c5
Driver: better landing pages
panglesd 63f50e8
compatibility
panglesd 6825e3c
Add a 'Home' link to breadcrumbs when no sidebar is given
panglesd 6779665
Fix default order of children
panglesd a4b69c2
Changelog entry for #1251
panglesd 5103c6b
Doc: page tags
panglesd ccf3f01
Doc: update canonical roots to the doclibless hierarchy
panglesd 3b53164
Index: add support for extension constructors
panglesd 9cf80ab
Remove now unused `handle_file` function
panglesd 5a15d21
Doc: explicitly make `@order_category` a driver-only tag
panglesd 4a6d2bd
Breadcrumbs: factor home breadcrumb
panglesd dea50a4
Breadcrumb: rename `escape-breadcrumb` to `home-breadcrumb`
panglesd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the cheatsheet be first ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though that the first thing was "how to build doc" before "how to write docs", which is why I put this page first, but I agree it is not ideal... I'll think about that a bit more.