Compatibility with OCaml 5.3 #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecated attribute is not accepted by OCaml 5.3.
Failing to init the lexer will result in keywords not being recognized with OCaml 5.3.
|
This is intended to be released on the 2.4 branch so I'll take care of the changelog later. |
Closed
Julow
force-pushed
the
compat-5.3
branch
3 times, most recently
from
3694218 to
117562d
Compare
|
Tests are failing on 4.04 and 4.06. |
On 4.04 and 4.06 (but not 4.02) this top-comment is lost.
|
This seems to be an issue in the parser. I found a workaround. |
|
CI is green, let's merge and cut a release ! |
Julow
added a commit
to Julow/opam-repository
that referenced
this pull request
Dec 5, 2024
CHANGES: ### Added - OCaml 5.3.0 compatibility (@Julow, ocaml/odoc#1202, ocaml/odoc#1254)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the compatibility then update the Opam constraints.