Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli: be more lenient with directory existence. #272

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Cli: be more lenient with directory existence. #272

merged 1 commit into from
Jan 11, 2019

Conversation

dbuenzli
Copy link
Contributor

@dbuenzli dbuenzli commented Dec 18, 2018 •
edited
Loading

Do not require -I directories to exist in compile command
(closes #35). Do not require the -o directory to exist in
*-targets commands (closes #170).

I have checked the transitive usage of convert_directory via dst a few lines below and I believe this to be correct.

@dbuenzli
Cli: be more lenient with directory existence.
2423c96 
Do not require -I directories to exist in `compile` command
(closes ocaml#35). Do not require the -o directory to exist in
`*-targets` commands (closes ocaml#170).
@aantron aantron merged commit 9b4b068 into ocaml:master Jan 11, 2019
@aantron
Copy link
Contributor

aantron commented Jan 11, 2019

Thanks

@dbuenzli dbuenzli deleted the fix-existing-dirs branch January 11, 2019 22:17
@dbuenzli dbuenzli mentioned this pull request Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonludlam jonludlam jonludlam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odoc html-target --dir DIR needs DIR to exist. -I $DIR option needs $DIR to exist
3 participants
@dbuenzli @aantron @jonludlam