Fix substitution of type params #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an explicit `'a or_replaced` type to better track where this need to be handled.
Julow
commented
Dec 4, 2020
Comment on lines
+642
to
+643
| | Replaced (TypeExpr.Constr (p, _), _) -> p | ||
| | Replaced _ -> (* What else is possible ? *) assert false |
There was a problem hiding this comment.
I'm not sure what we should do here. More tests are required
Julow
commented
Dec 7, 2020
test/xref2/subst/test.md
Outdated
| module M/68 : sig | ||
| type t/72 | ||
| include : S/69 with [root(S/69).t = [(alias (poly_var [ `A of (a * b) ]) b)] t/72] (sig = | ||
| val map/73 : ([(alias (poly_var [ `A of (a * b) ]) b)] t/72) -> ((a) -> b) -> [(alias (poly_var [ `A of (b * b) ]) b)] t/72 |
There was a problem hiding this comment.
I've found an edge case, the last type is wrong: (alias (poly_var [ A of (b * b) ]) b). We should either rename btoc` in this type or choose a free variable before substituting.
What do you think ?
Print type representation in declarations. Print polymorphic variants. Add missing parentheses around arrows arguments and shorten some paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #538 and #462
This substitutes recursively type variables when encountering a "replaced" type.