stop rendering overridden module vals #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happens, that this has to be merged first. |
|
You can import these changes in this PR like this: Git will be smart enough to remove them from your branch when #591 is merged and you rebase again on top of master |
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
lubegasimon
force-pushed
the
stop-documenting-overridden-module-vals
branch
2 times, most recently
from
0a44168 to
c77755f
Compare
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
lubegasimon
force-pushed
the
stop-documenting-overridden-module-vals
branch
from
c77755f to
4589202
Compare
Julow
approved these changes
Feb 19, 2021
| @@ -275,7 +313,7 @@ let extract_structure_tree_item item = | |||
| | Tstr_open o -> | |||
| ((extract_extended_open o) :> extracted_items list) | |||
| #endif | |||
| | Tstr_eval _ | Tstr_value _ | |||
| | Tstr_eval _ | |||
| | Tstr_primitive _ | Tstr_typext _ | |||
There was a problem hiding this comment.
Tstr_primitive binds a value too.
There was a problem hiding this comment.
This statement isn’t clear
There was a problem hiding this comment.
Tstr_primitive correspond to:
external f : unit -> unit = "%primitive_name"It should be treated as a value (as val f : unit -> unit)
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
lubegasimon
force-pushed
the
stop-documenting-overridden-module-vals
branch
from
15a350d to
d40779f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #508
after fix: