Fix unresolved references from the first comment of a file #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
force-pushed
the
references-scope
branch
from
62f30de to
3fbd055
Compare
To provide a more readable test output.
The first comment of a module would be linked with an empty environment. Also make sure that labels in that doc comment are added to the env.
Julow
force-pushed
the
references-scope
branch
from
3fbd055 to
6238376
Compare
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #585 but doesn't fix the issue reported by this comment #585 (comment)
Resolution failed because doc comment of a file was resolved before the rest of the module is added to the environment.
The first commit is unrelated, it removes the location from
odoc_print's output to make the output more readable.The second issue seems to be in the loader, I'm still investigating.