Fix a bug in subst noticed in uwt
#708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fixes and a test: 1. Slightly more recursion needed when expanding `module type of` expressions before compilation 2. In the presence of `module type of` expressions and `includes`, we can get in the situation when we try to rename elements that have been prefixed. This is not an error, though it is unusual. we end up labelling the items with different idents, but that's fine because all expressions referencing them are using the prefixed path anyway. The test is a much cut-down version of `uwt` that was originally demonstrating the problem, manifesting as an internal `Failure` begin raised
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Oct 5, 2021
CHANGES: Breaking changes - Remove odoc-parser into a separate repository (@jonludlam, ocaml/odoc#700) Additions - OCaml 4.13 support (@Octachron, ocaml/odoc#687, ocaml/odoc#689) - Better errors/warnings (@Julow, ocaml/odoc#692, ocaml/odoc#717, ocaml/odoc#720, ocaml/odoc#732) - ModuleType 'Alias' support (@jonludlam, ocaml/odoc#703) - Improved test suite (@lubega-simon, ocaml/odoc#697) - Improved documentation (@lubega-simon, @jonludlam, ocaml/odoc#702, ocaml/odoc#733) - Strengthen module types (@jonludlam, ocaml/odoc#731) Bugs fixed - `uwt` now can be documented (@jonludlam, ocaml/odoc#708) - Fix resolution involving deeply nested substitutions (@jonludlam, ocaml/odoc#727) - Fix off-by-one error in error reporting (@asavahista, ocaml/odoc#736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes and a test:
module type ofexpressions before compilation
module type ofexpressions andincludes,we can get in the situation when we try to rename elements that
have been prefixed. This is not an error, though it is unusual.
we end up labelling the items with different idents, but that's
fine because all expressions referencing them are using the
prefixed path anyway.
The test is a much cut-down version of
uwtthat was originallydemonstrating the problem, manifesting as an internal
Failurebegin raised.