Caqti 0.10.1

[paurkedal]

I found a bug which could lead to a deadlock, so I'd like to release the fix right away. Note that caqti-driver-mariadb is expected to fail to build due to issues with external dependencies for mariadb.

[camelus]

✅ All lint checks passed bb2f5d2

• These packages passed lint tests: caqti-async.0.10.1, caqti-driver-mariadb.0.10.1, caqti-driver-postgresql.0.10.1, caqti-driver-sqlite3.0.10.1, caqti-dynload.0.10.1, caqti-lwt.0.10.1, caqti-type-calendar.0.10.1, caqti.0.10.1

---

✅ Installability check (8350 → 8358)

• new installable packages (8): caqti.0.10.1 caqti-async.0.10.1 caqti-driver-mariadb.0.10.1 caqti-driver-postgresql.0.10.1
caqti-driver-sqlite3.0.10.1 caqti-dynload.0.10.1 caqti-lwt.0.10.1 caqti-type-calendar.0.10.1

[paurkedal]

I think CI is overloaded, so I'll not attempt any rebuilds myself right now.

[mseri]

In some casa it’s failing to run the tests:

# opam-version 1.2.2
# os           linux
# command      jbuilder runtest -p caqti -j 4
# path         /home/travis/.opam/4.04.2/build/caqti.0.10.1
# compiler     4.04.2
# exit-code    1
# env-file     /home/travis/.opam/4.04.2/build/caqti.0.10.1/caqti-13044-44e05c.env
# stdout-file  /home/travis/.opam/4.04.2/build/caqti.0.10.1/caqti-13044-44e05c.out
# stderr-file  /home/travis/.opam/4.04.2/build/caqti.0.10.1/caqti-13044-44e05c.err
### stderr ###
# Error: External library "caqti_dynload" not found.
# -> required by "tests/jbuild (context default)"
# Hint: try: jbuilder external-lib-deps --missing -p caqti @runtest

[paurkedal]

Yes, there are missing packages in the build-test specifications. I'm not sure how to do it yet, since the interesting tests dynamically loads drivers depending on a test configuration.

[paurkedal]

My solution for now is to move all tests into the caqti-driver-sqlite3 package and adjusted the -p option there. The main reason is that most tests depend on at least one database driver, and only sqlite3 will can be relied upon during CI.

A few tests could be run in caqti-async or caqti-lwt, but there is something I don't understand with respect to jbuilder: There are (package ...) filters for all tests that depend on caqti_dynload, so the failure we saw above should not have happened before the build system reached either the caqti-lwt or caqti-async package. I'll have to look into that, for now I'll leave all tests in the sqlite3 driver package.

(And apologies for the extra CI trigger, I forgot to add some test dependencies.)

[mseri]

Thanks for the update. Don't worry about the CI trigger

[kit-ty-kate]

Mmh, seems like the mariadb package does not depend on the conf-mariadb meta-package but instead have its own (not complete) depexts. This makes it fail on centos.
So I'm going to merge this and open a PR to fix this issue.

[kit-ty-kate]

Damn I missed a Travis failure:

#=== ERROR while installing caqti.0.10.1 ======================================#
# opam-version 1.2.2
# os           linux
# command      jbuilder runtest -p caqti -j 4
# path         /home/travis/.opam/4.05.0/build/caqti.0.10.1
# compiler     4.05.0
# exit-code    1
# env-file     /home/travis/.opam/4.05.0/build/caqti.0.10.1/caqti-13362-cc80cf.env
# stdout-file  /home/travis/.opam/4.05.0/build/caqti.0.10.1/caqti-13362-cc80cf.out
# stderr-file  /home/travis/.opam/4.05.0/build/caqti.0.10.1/caqti-13362-cc80cf.err
### stderr ###
# File "tests/jbuild", line 23, characters 1-88:
# Error: Library "caqti_lwt_v1" not found.
# 
# Hint: try: jbuilder external-lib-deps --missing -p caqti @runtest

Is this the error you were talking about ?

[paurkedal]

@jpdeplaix Yes, I should have suggested waiting till I had time to see though it. Though, probably people won't notice unless they request testing when installing the package. I'll send another PR to fix it.

[kit-ty-kate]

@paurkedal Thanks, it is much appreciated :) Sorry for merging this too soon.