Fix ocaml and ocaml-system packages to take .exe into account #11928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☀️ No new or changed opam files f402530☀️ Installability check (9054 → 9054) |
|
If this is in line with opam's rewrite code, it's OK to merge. We just should recompile and restart @camelus around the same time, so that it doesn't detect conflicts on changes to the wrapper compiler packages (which shouldn't happen often, and in the worst case, will make it file a PR that we'll have to ignore, so nothing critical) In other words: good to merge. |
|
@AltGr feel free to merge whenever you want. This is currently killing our CI as as basically recompile all the existing packages ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual application of the change to the upgrade process in ocaml/opam#3337 intended to unblock ocaml/opam#3336.
I don't know if this affects Camelus's rewriting as well - I think not, as the ocaml packages are maintained by hand but could opam-repository maintainers wait for @AltGr to review before merging this one.