Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caqti 0.11.0. #12052

Merged
merged 1 commit into from
May 31, 2018
Merged

Caqti 0.11.0. #12052

merged 1 commit into from
May 31, 2018

Conversation

paurkedal
Copy link
Contributor

Change Log for 0.11.0

Added and improved:

  • Compliance with Lwt 4.0 contributed by Brendan Long.
  • Switched to the logs library for logging.
  • Strengthen detection of concurrent use of connection.
  • Support microsecond precision for timestamps for PostgreSQL and
    millisecond for Sqlite3.
  • Use float for time spans in Sqlite3.
  • Map the octets type to BLOBs for MariaDB and Sqlite3.
  • Log recoverable errors for MariaDB and Sqlite3.

Removed:

  • The v1 API is now removed.

Ecosystem:

  • CI setup contributed by Brendan Long.
  • Various documentation updates.

@camelus
Copy link
Contributor

camelus commented May 25, 2018

✅ All lint checks passed e75215e
  • These packages passed lint tests: caqti-async.0.10.2, caqti-async.0.11.0, caqti-async.0.9.0, caqti-driver-mariadb.0.10.2, caqti-driver-mariadb.0.11.0, caqti-driver-mariadb.0.9.0, caqti-driver-postgresql.0.10.2, caqti-driver-postgresql.0.11.0, caqti-driver-postgresql.0.9.0, caqti-driver-sqlite3.0.10.2, caqti-driver-sqlite3.0.11.0, caqti-driver-sqlite3.0.9.0, caqti-dynload.0.10.2, caqti-dynload.0.11.0, caqti-dynload.0.9.0, caqti-lwt.0.10.2, caqti-lwt.0.11.0, caqti-lwt.0.9.0, caqti-type-calendar.0.10.2, caqti-type-calendar.0.11.0, caqti-type-calendar.0.9.0, caqti.0.11.0

✅ Installability check (8892 → 8900)
  • new installable packages (8): caqti.0.11.0 caqti-async.0.11.0 caqti-driver-mariadb.0.11.0 caqti-driver-postgresql.0.11.0
    caqti-driver-sqlite3.0.11.0 caqti-dynload.0.11.0 caqti-lwt.0.11.0 caqti-type-calendar.0.11.0

@paurkedal
Copy link
Contributor Author

paurkedal commented May 25, 2018

I'll need to strengthen some internal version constraints. Update: Done, internal dependencies are now version-exact.

@samoht
Copy link
Member

samoht commented May 25, 2018

You forgot a few constraint for ppx_sexp_conv (the new packages have a runtime library as well).

#=== ERROR while installing caqti-driver-sqlite3.0.10.2 =======================#
# opam-version 1.2.2
# os           linux
# command      jbuilder build -p caqti-driver-sqlite3 -j 4
# path         /home/travis/.opam/system/build/caqti-driver-sqlite3.0.10.2
# compiler     system (4.06.1)
# exit-code    1
# env-file     /home/travis/.opam/system/build/caqti-driver-sqlite3.0.10.2/caqti-driver-sqlite3-7959-e0259d.env
# stdout-file  /home/travis/.opam/system/build/caqti-driver-sqlite3.0.10.2/caqti-driver-sqlite3-7959-e0259d.out
# stderr-file  /home/travis/.opam/system/build/caqti-driver-sqlite3.0.10.2/caqti-driver-sqlite3-7959-e0259d.err
### stderr ###
# File "/home/travis/.opam/system/lib/uri/META", line 1, characters 0-0:
# Error: Library "ppx_sexp_conv.runtime-lib" not found.
# -> required by library "uri" in /home/travis/.opam/system/lib/uri
# Hint: try: jbuilder external-lib-deps --missing -p caqti-driver-sqlite3 @install
#=== ERROR while installing caqti-dynload.0.10.2 ==============================#
# opam-version 1.2.2
# os           linux
# command      jbuilder build -p caqti-dynload -j 4
# path         /home/travis/.opam/system/build/caqti-dynload.0.10.2
# compiler     system (4.06.1)
# exit-code    1
# env-file     /home/travis/.opam/system/build/caqti-dynload.0.10.2/caqti-dynload-7959-6d487c.env
# stdout-file  /home/travis/.opam/system/build/caqti-dynload.0.10.2/caqti-dynload-7959-6d487c.out
# stderr-file  /home/travis/.opam/system/build/caqti-dynload.0.10.2/caqti-dynload-7959-6d487c.err
### stderr ###
# File "/home/travis/.opam/system/lib/uri/META", line 1, characters 0-0:
# Error: Library "ppx_sexp_conv.runtime-lib" not found.
# -> required by library "uri" in /home/travis/.opam/system/lib/uri
# Hint: try: jbuilder external-lib-deps --missing -p caqti-dynload @install

@paurkedal
Copy link
Contributor Author

You forgot a few constraint for ppx_sexp_conv (the new packages have a runtime library as well).

Caqti does not use ppx_sexp_conv directly. The missing dependency belongs to uri, and this is covered by the larger issue #11852.

@kit-ty-kate
Copy link
Member

Ok, I investigated the ppx_sexp_conv.runtime-lib issue today and I can't explain it. Everything was at the right place and dependencies were correctly set. I can't explain how relaunching the Travis runs fixed the problem either…

The problem was that ppx_sexp_conv was installed after caqti-dynload and others, so I guess a dependency was missing somewhere but I couldn't find the cause.

Oh well, seems ok now. Merging. Thanks!

@kit-ty-kate kit-ty-kate merged commit bbe0edb into ocaml:master May 31, 2018
@paurkedal
Copy link
Contributor Author

@kit-ty-kate Thanks! I actually triggered the rebuild by a rebase on the current master, integrating the ppx dependency fix, so that should explain why the problem went away. As for how it broke in the first place, the uri library was probably upgraded (maybe due to the version constraint), which triggered a reinstall, which can fail when there is a wrong {build} in the constraints, as illustrated by the issue.

@paurkedal paurkedal deleted the caqti-0.11.0 branch May 31, 2018 19:05
@kit-ty-kate
Copy link
Member

@paurkedal mmh, when did you triggered the rebuild ?

@paurkedal
Copy link
Contributor Author

@kit-ty-kate Today at 17:11:56 UTC.

@kit-ty-kate
Copy link
Member

Mmh that might be it but I also triggered a rebuild around this time and that should have had the same effect ^^"

@paurkedal
Copy link
Contributor Author

No, merely triggering a rebuild should not affect the outcome in this case. If you rebuilt before the rebase, the branch used would still include the ppx dependency bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants