Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx_import: add bound on ocaml version #12137

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

damiendoligez
Copy link
Member

ppx_import won't compile on 4.07 because Ident.t is now an abstract type.
Fix sent upstream: ocaml-ppx/ppx_import#23.

cc @whitequark

I also had to fix the download URLs because the project moved from whitequark to ocaml-ppx.

@camelus
Copy link
Contributor

camelus commented Jun 7, 2018

✅ All lint checks passed 5d60fec
  • These packages passed lint tests: ppx_import.1.4

✅ Installability check (8937 → 8937)

@yomimono
Copy link
Member

yomimono commented Jun 7, 2018

Revdep failure is a failure to pull the source for systemverilog and everything else looks fine. Thanks, @damiendoligez !

@yomimono yomimono merged commit b0780c5 into ocaml:master Jun 7, 2018
@damiendoligez damiendoligez deleted the ppx_import-add-bound branch June 8, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants