Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nocrypto: Fix patches for *BSD #12253

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Nocrypto: Fix patches for *BSD #12253

merged 1 commit into from
Jun 27, 2018

Conversation

copy
Copy link
Contributor

@copy copy commented Jun 26, 2018

Patches were created using git format-patch --no-renames. See #12252.

cc @hannesm @mseri

Fixes application of these patches on non-gnu systems
@copy
Copy link
Contributor Author

copy commented Jun 26, 2018

It looks like the release tarball differs from the 0.5.4 branch in that %%VERSION_NUM%% was replaced by 0.5.4. So the patches (which were created from the 0.5.4 branch) didn't apply to the release tarball. I have edited the patch files manually for now.

@camelus
Copy link
Contributor

camelus commented Jun 26, 2018

✅ All lint checks passed 8dd9781
  • These packages passed lint tests: nocrypto.0.5.4-1

✅ Installability check (9032 → 9032)

@mseri
Copy link
Member

mseri commented Jun 27, 2018

Seems to have worked. Thanks

@mseri mseri merged commit 483c36d into ocaml:master Jun 27, 2018
@hannesm
Copy link
Member

hannesm commented Jul 5, 2018

did anyone test this on either FreeBSD or OpenBSD? At least on my FreeBSD-11 system, patch 0003 results in an empty META file which is then installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants