Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sundials v3.1.1p0 release #12341

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Sundials v3.1.1p0 release #12341

merged 1 commit into from
Jul 14, 2018

Conversation

tbrk
Copy link
Contributor

@tbrk tbrk commented Jul 12, 2018 •
edited
Loading

New release of Sundials. Update to install package.

@camelus
Copy link
Contributor

camelus commented Jul 12, 2018 •
edited
Loading

✅ All lint checks passed a92b312
  • These packages passed lint tests: sundialsml.3.1.1p0
✅ Installability check (9122 → 9123)
  • new installable packages (1): sundialsml.3.1.1p0

@tbrk
Copy link
Contributor Author

tbrk commented Jul 12, 2018 •
edited
Loading

The Ubuntu LTS and Alpine builds fail because the CI does not seem to be able to install the depexts.
For CentOS, I will adapt the Sundials/ML configure script.
Debian testing and unstable fail because the depexts are different than those for stable; is it possible to give different depexts for different versions of debian in the opam files? (I read some of the issue reports for opam but without really understanding what I should do.)

@tbrk tbrk force-pushed the sundialsml branch 3 times, most recently from 87a4812 to 672a081 Compare July 12, 2018 21:15
@tbrk
Copy link
Contributor Author

tbrk commented Jul 12, 2018 •
edited
Loading

OK. CentOS is fixed.

Without some kind of versioning for depexts, it's not possible to simultaneously support Debian stable, testing, and unstable because the required package names change. ocaml/opam#2168

I don't think I can fix the Alpine and Ubuntu LTS CI dependency problems.

@tbrk tbrk force-pushed the sundialsml branch 5 times, most recently from ff0d2ae to 763ef8d Compare July 13, 2018 13:46
@kit-ty-kate
Copy link
Member

Yeah, that's a bit annoying but oh well. Hopefully it'll get better once opam2 will be released.
Could you add the {build} attribute to ocamlfind though? I'll merge it afterwards.

@tbrk
Copy link
Contributor Author

tbrk commented Jul 14, 2018 •
edited
Loading

{build} added. Thanks for spotting that.

@kit-ty-kate kit-ty-kate merged commit b523d85 into ocaml:master Jul 14, 2018
@kit-ty-kate
Copy link
Member

Thanks!

@tbrk tbrk deleted the sundialsml branch July 14, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs reporter action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbrk @camelus @kit-ty-kate