ocamlbuild.0.13.1 #12586
ocamlbuild.0.13.1 #12586
Conversation
✅ All lint checks passed 13af7e3
✅ Installability check (9316 → 9317)
|
|
All the failures seems to be independent of this. I've seen not updated ast for 4.06, missing support for safe-string and network probles. I think this is safe to merge. I'll leave it open if somebody wants to double check first |
|
I agree, and/but I started working on a small PR to version-bound some of the unsafe-string revdeps appropriately: master...gasche:ocamlbuild-revdep-fixes soon in a PR near you! |
Some failures are new and don't seem to be related to safe string, e.g: |
|
@fdopen thanks! I'll have a look. Out of curiosity, how did you spot this one? Are there more when it comes from? |
|
So, this is indeed a regression due to a change of behavior in ocamlbuild, more precisely the addition of the "link" tag to "pack" actions. This package is using I think that the package is wrong here (I don't see a reason to use I'm happy to do another round and replace this with a 0.13.1 release, but it would be nicer if we could have a reasonable sense of whether other regressions are waiting in the CI results, lost in the noise of |
|
I just rebased the present PR with a 0.13.1 release that fixes the webidl build (and wasm, which was also affected) without requiring upstream package changes. I will try to look at the revdeps more carefully this time to see if more packages are affected. |
gasche
force-pushed
the
ocamlbuild.0.13.0
branch
from
9c5b7bb to
4afa59d
Compare
OCamlbuild 0.13.0 contains new features (`ppopt(..)` and `ppxopt(...)` flags, ocamlbuild options) and bugfixes (to pack production, for 4.08+dev support). - ocaml/ocamlbuild#45, ocaml/ocamlbuild#190: add ppopt(arg) and ppxopt(package,arg) when -use-ocamlfind (Gabriel Scherer, review by whitequark, request by Gabriel Scherer, Gabriel Radanne and Pavel Argentov) - ocaml/ocamlbuild#268, ocaml/ocamlbuild#269: add flag support for some ocamlmklib options: custom, debug, failsafe, linkall, ccopt(..), cclib(..), rpath(..), ldopt(..) (Gabriel Scherer, report by Hannes Mehnert, review by whitequark) * ocaml/ocamlbuild#272: add the "link" tag to "pack" actions Instead of a separate category, "pack" is now another form of linking like "program", "library", "toplevel" and "output_obj". This fixes the issue that package(...) tags where not passed at pack-production time, spotted by Jérémie Dimino. More generally, this extends the meaning of all "link" flags to "pack", which seems to be the correct behavior for all the rules we inspected. (Gabriel Scherer, original issue diagnosis by Jérémie Dimino) - ocaml/ocamlbuild#278: typo fixes in the manual (Xinzhe Yang) - ocaml/ocamlbuild#282: fix compilation with trunk OCaml (4.08+dev) (Xavier Clerc and Nandor Licker)
This bugfix release attempts to fix a regression due to the change in "pack" handling in 0.13.0. It is not clear whether the regression should be considered a bug in 0.13.0 or an incorrect _tags file in the broken package, but we prefer to fix it anyway. - ocaml/ocamlbuild#287: change "linkpkg" flag definition to not apply in the new "pack"++"link" mode introduced by ocaml/ocamlbuild#272. This avoids a build failure in webidl.1.4 and possibly other packages using "true: linkpkg". (Gabriel Scherer, report by Andreas Hauptmann)
|
This sounds still like the previous error:
|
|
This is weird, I thought I had checked that Anyway, I won't have time to work on this before early October, so the release will have to wait. Sorry for the delay. |
|
@gasche should I close this PR in the meantime? |
|
(migration to opam2 is happening today anyway) |
|
The |
|
I'll close this until @gasche gets a chance to revisit in October. |
OCamlbuild 0.13.0 contains new features (
ppopt(..)andppxopt(...)flags,ocamlbuild options) and bugfixes (to pack production, for 4.08+dev support).
ppopt and ppxopt options ocamlbuild#45, MPR#6103: Add ocamlbuild support for ocamlfind's -ppopt option ocamlbuild#190: add ppopt(arg) and ppxopt(package,arg) when -use-ocamlfind
(Gabriel Scherer, review by whitequark,
request by Gabriel Scherer, Gabriel Radanne and Pavel Argentov)
How to generate only a statically linked clib? ocamlbuild#268, #268: add flag support for ocamlmklib options ocamlbuild#269: add flag support for some ocamlmklib options:
custom, debug, failsafe, linkall, ccopt(..), cclib(..), rpath(..), ldopt(..)
(Gabriel Scherer, report by Hannes Mehnert, review by whitequark)
packaction must also passpackage(...)options to ocamlfind ocamlbuild#272: add the "link" tag to "pack" actionsInstead of a separate category, "pack" is now another form of linking
like "program", "library", "toplevel" and "output_obj". This fixes
the issue that package(...) tags where not passed at pack-production
time, spotted by Jérémie Dimino. More generally, this extends
the meaning of all "link" flags to "pack", which seems to be the correct
behavior for all the rules we inspected.
(Gabriel Scherer, original issue diagnosis by Jérémie Dimino)
typo ocamlbuild#278: typo fixes in the manual
(Xinzhe Yang)
Fix compilation for OCaml 4.08 ocamlbuild#282: fix compilation with trunk OCaml (4.08+dev)
(Xavier Clerc and Nandor Licker)