-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add opam package for pfff, just the parsing libraries #1300
Conversation
Summary: This is the Initial version of pfff opam package. It just installs the different parsing libraries. In the next week I'll try to update it to also install sgrep, spatch, stags, scheck, and later codemap and codegraph. But for now, let's just install the libraries. Js_of_ocaml recently copy pasted the js parser in pfff just because it was not easily accessible as a standalone library. Test Plan: put this package in my ~/testing repo opam update testing opam install pfff => it works, it installs pfff-xxx libraries opam uninstall pfff => it works, it uninstalls pfff-xxx libraries
Great! Could the various libraries be separate OPAM packages too? That will help with finer grained dependencies (eg jsofocaml doesn't need the rest of pfff)
|
I don't plan to split the pfff repo, so even if I make different packages, in the end they will all |
Is it ok to have many packages that in the end use the same archive? |
Multiple packages that use the same archive is just fine (Mirage does that too). You can have separate build commands for each one (to install just the library for example). One tweak before merging this: could you add an OCaml version constraint to be greater than 3.12.1?
3.12.1 failing log here; https://travis-ci.org/ocaml/opam-repository/jobs/13946836 |
I love travis |
add opam package for pfff, just the parsing libraries
When I do opam update; opam list |grep pfff I don't see anything. |
Are you still using OPAM 1.0 by any chance, or OPAM 1.1? If you're using OPAM 1.1 and the default HTTP remote, it should redirect you to the new opam.ocaml.org. However, if you have a local repository (i.e. opam init git://github.com//opam-repository) then the redirect won't happen. You can fix this by deleting the default remote and adding the new one by hand, or simply deleting ~/.opam and doing an -anil On 20 Nov 2013, at 04:43, Yoann Padioleau notifications@github.com wrote:
|
yep, it worked, opam upgrade process looks pretty solid :) |
Summary:
This is the Initial version of pfff opam package. It just installs
the different parsing libraries. In the next week I'll
try to update it to also install sgrep, spatch, stags,
scheck, and later codemap and codegraph. But for now,
let's just install the libraries. Js_of_ocaml recently
copy pasted the js parser in pfff just because it
was not easily accessible as a standalone library.
Test Plan:
put this package in my ~/testing repo
opam update testing
opam install pfff
=> it works, it installs pfff-xxx libraries
opam uninstall pfff
=> it works, it uninstalls pfff-xxx libraries