Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opam package for pfff, just the parsing libraries #1300

Merged
merged 2 commits into from
Nov 15, 2013
Merged

Conversation

aryx
Copy link
Contributor

@aryx aryx commented Nov 14, 2013

Summary:
This is the Initial version of pfff opam package. It just installs
the different parsing libraries. In the next week I'll
try to update it to also install sgrep, spatch, stags,
scheck, and later codemap and codegraph. But for now,
let's just install the libraries. Js_of_ocaml recently
copy pasted the js parser in pfff just because it
was not easily accessible as a standalone library.

Test Plan:
put this package in my ~/testing repo
opam update testing
opam install pfff
=> it works, it installs pfff-xxx libraries
opam uninstall pfff
=> it works, it uninstalls pfff-xxx libraries

Summary:
This is the Initial version of pfff opam package. It just installs
the different parsing libraries. In the next week I'll
try to update it to also install sgrep, spatch, stags,
scheck, and later codemap and codegraph. But for now,
let's just install the libraries. Js_of_ocaml recently
copy pasted the js parser in pfff just because it
was not easily accessible as a standalone library.

Test Plan:
put this package in my ~/testing repo
opam update testing
opam install pfff
 => it works, it installs pfff-xxx libraries
opam uninstall pfff
 => it works, it uninstalls pfff-xxx libraries
@avsm
Copy link
Member

avsm commented Nov 14, 2013

Great! Could the various libraries be separate OPAM packages too? That will help with finer grained dependencies (eg jsofocaml doesn't need the rest of pfff)

On 13 Nov 2013, at 17:27, Yoann Padioleau notifications@github.com wrote:

Summary:
This is the Initial version of pfff opam package. It just installs
the different parsing libraries. In the next week I'll
try to update it to also install sgrep, spatch, stags,
scheck, and later codemap and codegraph. But for now,
let's just install the libraries. Js_of_ocaml recently
copy pasted the js parser in pfff just because it
was not easily accessible as a standalone library.

Test Plan:
put this package in my ~/testing repo
opam update testing
opam install pfff
=> it works, it installs pfff-xxx libraries
opam uninstall pfff
=> it works, it uninstalls pfff-xxx libraries

You can merge this Pull Request by running

git pull https://github.com/aryx/opam-repository master
Or view, comment on, or merge it at:

#1300

Commit Summary

add opam package for pfff, just the parsing libraries
File Changes

A packages/pfff.0.25.1/descr (14)
A packages/pfff.0.25.1/opam (13)
A packages/pfff.0.25.1/url (2)
Patch Links:

https://github.com/ocaml/opam-repository/pull/1300.patch
https://github.com/ocaml/opam-repository/pull/1300.diff

@aryx
Copy link
Contributor Author

aryx commented Nov 14, 2013

I don't plan to split the pfff repo, so even if I make different packages, in the end they will all
fetch the pfff.tar.gz and compile most things.

@aryx
Copy link
Contributor Author

aryx commented Nov 14, 2013

Is it ok to have many packages that in the end use the same archive?

@avsm
Copy link
Member

avsm commented Nov 14, 2013

Multiple packages that use the same archive is just fine (Mirage does that too). You can have separate build commands for each one (to install just the library for example).

One tweak before merging this: could you add an OCaml version constraint to be greater than 3.12.1?

ocaml-version: [>="4.00.0"]

3.12.1 failing log here; https://travis-ci.org/ocaml/opam-repository/jobs/13946836

@aryx
Copy link
Contributor Author

aryx commented Nov 14, 2013

I love travis

avsm added a commit that referenced this pull request Nov 15, 2013
add opam package for pfff, just the parsing libraries
@avsm avsm merged commit 464a32d into ocaml:master Nov 15, 2013
@aryx
Copy link
Contributor Author

aryx commented Nov 20, 2013

When I do opam update; opam list |grep pfff I don't see anything.
Is it normal? How long it takes to get the package be reflected in the opam of the users?
Is it because I've installed opam a few months ago and it's not up to date with opam.ocaml.org
(opam update still metions opam.ocamlpro.com).

@avsm
Copy link
Member

avsm commented Nov 20, 2013

Are you still using OPAM 1.0 by any chance, or OPAM 1.1?

If you're using OPAM 1.1 and the default HTTP remote, it should redirect you to the new opam.ocaml.org. However, if you have a local repository (i.e. opam init git://github.com//opam-repository) then the redirect won't happen. You can fix this by deleting the default remote and adding the new one by hand, or simply deleting ~/.opam and doing an opam init again.

-anil

On 20 Nov 2013, at 04:43, Yoann Padioleau notifications@github.com wrote:

When I do opam update; opam list |grep pfff I don't see anything.
Is it normal? How long it takes to get the package be reflected in the opam of the users?
Is it because I've installed opam a few months ago and it's not up to date with opam.ocaml.org
(opam update still metions opam.ocamlpro.com).


Reply to this email directly or view it on GitHub.

@aryx
Copy link
Contributor Author

aryx commented Nov 21, 2013

yep, it worked, opam upgrade process looks pretty solid :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants