Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-freestanding 0.4.3 #13679

Closed
wants to merge 1 commit into from
Closed

Conversation

mato
Copy link
Contributor

@mato mato commented Mar 14, 2019

No description provided.

@camelus
Copy link
Contributor

camelus commented Mar 14, 2019

☀️ All lint checks passed 6ab4b6b
  • These packages passed lint tests: ocaml-freestanding.0.4.3

☀️ Installability check (10825 → 10826)
  • new installable packages (1): ocaml-freestanding.0.4.3

@mseri
Copy link
Member

mseri commented Mar 14, 2019

The system switch test fails with

#=== ERROR while installing ocaml-freestanding.0.4.3 ==========================#
# context     2.0.0 | linux/x86_64 | ocaml-system.4.06.1 | file:///home/travis/build/ocaml/opam-repository
# path        ~/.opam/ocaml-system/.opam-switch/build/ocaml-freestanding.0.4.3
# command     ~/.opam/opam-init/hooks/sandbox.sh install make install PREFIX=/home/travis/.opam/ocaml-system
# exit-code   2
# env-file    ~/.opam/log/ocaml-freestanding-11425-c743ac.env
# output-file ~/.opam/log/ocaml-freestanding-11425-c743ac.out
### output ###
# [...]
# +cp build/ocaml/byterun/caml/mlvalues.h /home/travis/.opam/ocaml-system/include/ocaml-freestanding/caml/mlvalues.h
# +cp build/ocaml/byterun/caml/printexc.h /home/travis/.opam/ocaml-system/include/ocaml-freestanding/caml/printexc.h
# +cp build/ocaml/byterun/caml/signals.h /home/travis/.opam/ocaml-system/include/ocaml-freestanding/caml/signals.h
# +cp build/ocaml/byterun/caml/compatibility.h /home/travis/.opam/ocaml-system/include/ocaml-freestanding/caml/compatibility.h
# +cp build/ocaml/byterun/caml/bigarray.h /home/travis/.opam/ocaml-system/include/ocaml-freestanding/caml/bigarray.h
# +cp build/ocaml/byterun/caml/m.h /home/travis/.opam/ocaml-system/include/ocaml-freestanding/caml/m.h
# +cp build/ocaml/byterun/caml/s.h /home/travis/.opam/ocaml-system/include/ocaml-freestanding/caml/s.h
# +cp build/ocaml/asmrun/libasmrun.a /home/travis/.opam/ocaml-system/lib/ocaml-freestanding/libasmrun.a
# +ln -s /home/travis/.opam/ocaml-system/lib/ocaml-freestanding/libasmrun.a /home/travis/.opam/ocaml-system/lib/ocaml/libasmrunfreestanding.a
# ln: failed to create symbolic link '/home/travis/.opam/ocaml-system/lib/ocaml/libasmrunfreestanding.a': No such file or directory
# Makefile:122: recipe for target 'install' failed
# make: *** [install] Error 1

@mato
Copy link
Contributor Author

mato commented Mar 15, 2019

@mseri Thanks for digging out the failure. This is due to the changes in mirage/ocaml-solo5#50, @pascutto / @TheLortex can you look into this please and let me know what you want me to do?

@TheLortex
Copy link
Contributor

TheLortex commented Mar 15, 2019

We had this issue with mirage-platform too. The problem is that a symlink was done in the ocaml library path, but that doesn't work in a system switch because of permissions.
The problem is introduced in mirage/ocaml-solo5@3dfba6a
We found a workaround with the ocaml compiler so you can just revert this commit, and then the CI should pass.

"sexplib" {= "v0.9.0"}
"solo5-kernel-ukvm"
"solo5-kernel-virtio"
"solo5-kernel-muen"
Copy link
Member

@samoht samoht Mar 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"solo5-kernel-muen"
"solo5-kernel-muen"
"ocaml-system"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather be in favour to close this PR and release ocaml-freestanding without the symlink (as PR'ed in mirage/ocaml-solo5#51, same for xen mirage/mirage-platform#208)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He someone is keen to do the work, yes sur no pb :p if not we can just merge this PR (as we did for mirage-platform) and wait for the next release to get support for the system compiler.

@mato
Copy link
Contributor Author

mato commented Mar 17, 2019

I've merged mirage/ocaml-solo5#51 (thanks @hannesm!) which reverts the symlink changes, will cut an 0.4.4 release shortly and open a new PR for that.

@mato mato closed this Mar 17, 2019
@mato mato mentioned this pull request Mar 17, 2019
@mato mato deleted the ocaml-freestanding.0.4.3 branch March 4, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants