-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocaml-freestanding 0.4.3 #13679
ocaml-freestanding 0.4.3 #13679
Conversation
☀️ All lint checks passed 6ab4b6b
☀️ Installability check (10825 → 10826)
|
The system switch test fails with
|
@mseri Thanks for digging out the failure. This is due to the changes in mirage/ocaml-solo5#50, @pascutto / @TheLortex can you look into this please and let me know what you want me to do? |
We had this issue with |
"sexplib" {= "v0.9.0"} | ||
"solo5-kernel-ukvm" | ||
"solo5-kernel-virtio" | ||
"solo5-kernel-muen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"solo5-kernel-muen" | |
"solo5-kernel-muen" | |
"ocaml-system" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather be in favour to close this PR and release ocaml-freestanding without the symlink (as PR'ed in mirage/ocaml-solo5#51, same for xen mirage/mirage-platform#208)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He someone is keen to do the work, yes sur no pb :p if not we can just merge this PR (as we did for mirage-platform) and wait for the next release to get support for the system compiler.
I've merged mirage/ocaml-solo5#51 (thanks @hannesm!) which reverts the symlink changes, will cut an 0.4.4 release shortly and open a new PR for that. |
No description provided.