-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql_parser.0.11.0: fix missing result
dependency.
#13803
Conversation
Sorry about that, and thanks for the fix. I'll make sure it's fixed with next release. |
Thanks |
☀️ All lint checks passed 8439b65
☀️ Installability check (10916 → 10916) |
This is now causing my build to fail. I'm not sure why. I'm using ocaml 4.06 so it shouldn't be an issue, right? Edit: Forcing the dependency on 0.9.0 makes it work again. |
@phated without failure details it's going to be hard to say anything. |
Also it seems this was merged after the |
It was using |
Precisely this PR fixes this error. |
But I was on graphql_parser 0.11.0 unless this overwrote an 0.11.0 version instead of incrementing the version? |
Yes it did. It seems we still don't have a good answer to this see #10531 |
I don't understand how this PR is fixing the issue ; |
Humpf. Right, to both. I'll PR a constraint. |
See See #13808 |
It seems graphql_parser.0.11.0 is getting its
result
dependency indirectly throughfmt
. But the latest release offmt
drops theresult
dependency which results in a build failure.This PR adds a dependency on
result
(note that e.g.0.9.0
has the dependency on `result)./cc @andreas