Fix dune 2.0's revdeps #15282
Merged
Fix dune 2.0's revdeps #15282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re and misses dune-project file)
…ses dune-project file)
…e and misses dune-project file)
…ature via ounit and misses dune-project file)
|
Should I add a dune-project file in those packages so that they are future-proof regarding dune? |
|
Yes, that is what we recommend.
…On Nov 15, 2019, 10:27 AM +0900, Francois Berenger ***@***.***>, wrote:
Should I add a dune-project file in those packages so that they are future-proof regarding dune?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Ok, I'll do some bugfix releases for those packages then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken packages with dune 2.0 discovered in #15261
cc @rgrinberg
minicliandlz4_chansfluent-loggerReasons for each fixes are noted in the commit message. More details here: #15261 (comment)