[new release] gobba (0.4.1) #15690
Merged
[new release] gobba (0.4.1) #15690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0f0f0f
force-pushed
the
release-gobba-0.4.1
branch
2 times, most recently
from
cb87a18 to
1d28833
Compare
kit-ty-kate
reviewed
Jan 18, 2020
packages/gobba/gobba.0.4.1/opam
Outdated
|
|
||
| build: [ | ||
| ["dune" "build" "-p" name "-j" jobs] | ||
| [make "test" "-j" jobs] {with-test} |
There was a problem hiding this comment.
Suggested change
| [make "test" "-j" jobs] {with-test} | |
| ["sh" "-c" "GOBBA_EXAMPLES=$(realpath ./examples/) dune runtest -p %{name}% -j %{jobs}%"] {with-test} | |
| ["sh" "-c" "bisect-ppx-report -html coverage/ -I _build/default _build/default/test/bisect*.out"] {with-test} |
This should be much better.
What is in your makefile is not correct for releases:
dune clean
dune build -j $(JOBS)
dune build @install
GOBBA_EXAMPLES=$(realpath ./examples/) dune runtest -f
bisect-ppx-report -html coverage/ -I _build/default _build/default/test/bisect*.out;
First of all, dune should never be called in releases without -p name or --profile=release, this might break this package in the future as dune turns some warnings as error by default. Then the package is built twice (dune build -p name -j jobs above, then dune clean & dune build again), this is unnecessary.
There was a problem hiding this comment.
Thank you for your dozens of suggestions!
0x0f0f0f
force-pushed
the
release-gobba-0.4.1
branch
from
1d28833 to
6b3dd71
Compare
kit-ty-kate
reviewed
Jan 18, 2020
packages/gobba/gobba.0.4.1/opam
Outdated
| build: [ | ||
| ["dune" "build" "-p" name "-j" jobs] | ||
| ["sh" "-c" "GOBBA_EXAMPLES=$(realpath ./examples/) dune runtest -p %{name}% -j %{jobs}%"] {with-test} | ||
| ["sh" "-c" "bisect-ppx-report -html coverage/ -I _build/default _build/default/test/bisect*.out"] {with-test} |
There was a problem hiding this comment.
Suggested change
| ["sh" "-c" "bisect-ppx-report -html coverage/ -I _build/default _build/default/test/bisect*.out"] {with-test} |
Arf sorry that's not working and needs rewiring (see ocaml/dune#57), but also this makes no sense for opam users anyway. I think having only the runtest phase is good enough, my bad.
CHANGES: - Renamed project from minicaml to `gobba`! - Syntax is now more haskel-ly: use `,` to separate list and dictionary values, use `>>` to sequence operations (bind) and use `;` to end statements. - Improved purity inference algorithm with correct module inference - Some minor improvements
0x0f0f0f
force-pushed
the
release-gobba-0.4.1
branch
from
6b3dd71 to
73068aa
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple, didactical, purely functional programming language
CHANGES:
gobba!,to separate list and dictionary values,use
>>to sequence operations (bind) and use;to end statements.