Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] inquire (0.1.0) #15839

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Conversation

tmattio
Copy link
Contributor

@tmattio tmattio commented Feb 13, 2020

An OCaml library to create beautiful interactive CLIs

CHANGES:

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog,
and this project adheres to Semantic Versioning.

Unreleased

0.1.0 - 2020-02-12

Added

  • Add confirm prompt.
  • Add input prompt.
  • Add password prompt.
  • Add raw_list prompt.

@kit-ty-kate
Copy link
Member

This package fails to build with OCaml 4.04 and 4.05 with the following error:

# (cd _build/default && /home/opam/.opam/4.04/bin/ocamlc.opt -open Base -g -bin-annot -I lib/.Inquire.objs/byte -I /home/opam/.opam/4.04/lib/base -I /home/opam/.opam/4.04/lib/base/base_internalhash_types -I /home/opam/.opam/4.04/lib/base/caml -I /home/opam/.opam/4.04/lib/base/shadow_stdlib -I /home/opam/.opam/4.04/lib/bytes -I /home/opam/.opam/4.04/lib/camomile -I /home/opam/.opam/4.04/lib/camomile/default_config -I /home/opam/.opam/4.04/lib/camomile/dyn -I /home/opam/.opam/4.04/lib/camomile/lib_default -I /home/opam/.opam/4.04/lib/camomile/library -I /home/opam/.opam/4.04/lib/charInfo_width -I /home/opam/.opam/4.04/lib/lambda-term -I /home/opam/.opam/4.04/lib/lwt -I /home/opam/.opam/4.04/lib/lwt/unix -I /home/opam/.opam/4.04/lib/lwt_log -I /home/opam/.opam/4.04/lib/lwt_log/core -I /home/opam/.opam/4.04/lib/lwt_react -I /home/opam/.opam/4.04/lib/mmap -I /home/opam/.opam/4.04/lib/ocaml/threads -I /home/opam/.opam/4.04/lib/ocplib-endian -I /home/opam/.opam/4.04/lib/react -I /home/opam/.opam/4.04/lib/result -I /home/opam/.opam/4.04/lib/seq -I /home/opam/.opam/4.04/lib/sexplib0 -I /home/opam/.opam/4.04/lib/zed -no-alias-deps -open Inquire__ -o lib/.Inquire.objs/byte/inquire__Raw_list.cmo -c -impl lib/prompts/raw_list.ml)
# File "lib/prompts/raw_list.ml", line 8, characters 6-28:
# Error: Unbound value Caml.int_of_string_opt
#       ocamlc lib/.Inquire.objs/byte/inquire__Input.{cmi,cmo,cmt}

An constraint on OCaml might be required

@tmattio tmattio force-pushed the release-inquire-0.1.0 branch 2 times, most recently from 163b032 to 7d8f0f5 Compare February 15, 2020 00:06
@camelus
Copy link
Contributor

camelus commented Feb 15, 2020

Commit: 910d9af

Hello @tmattio! I believe this is your first contribution here. Please be nice, reviewers!

☀️ All lint checks passed 910d9af
  • These packages passed lint tests: inquire.0.1.0

☀️ Installability check (+1)
  • new installable packages (1): inquire.0.1.0

@kit-ty-kate
Copy link
Member

The archive changed again:

[ERROR] The sources of the following couldn't be obtained, aborting:
          - inquire.0.1.0:
            https://github.com/tmattio/inquire/releases/download/v0.1.0/inquire-v0.1.0.tbz (Bad checksum, expected sha256=aa5cf3b1a372a89019ffe52245000f6f80596d4cc81dc5d081397c5dff6b45e3)

@tmattio
Copy link
Contributor Author

tmattio commented Feb 15, 2020

Hi @kit-ty-kate, thanks for putting the error here!

The checksum in the generated Opam file is wrong, which is strange because I've simply used dune-release and it took care of uploading the tbz on Github and openning a PR here. Do you have any idea what could have gone wrong?

Worst case I'll just put the checksum manually but I'd like to keep the release automatated.

@tmattio tmattio force-pushed the release-inquire-0.1.0 branch from 7d8f0f5 to 11a349a Compare February 18, 2020 23:15
CHANGES:

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.1.0] - 2020-02-12

### Added

- Add `confirm` prompt.
- Add `input` prompt.
- Add `password` prompt.
- Add `raw_list` prompt.

[Unreleased]: tmattio/spin@v0.1.0...HEAD
[0.1.0]: https://github.com/tmattio/spin/releases/tag/v0.1.0
@tmattio tmattio force-pushed the release-inquire-0.1.0 branch from bbf585b to 910d9af Compare February 19, 2020 09:01
@kit-ty-kate
Copy link
Member

Dune should not be tagged as a build dependency (see #14266). Could you return the fixes upstream?

Otherwise this PR is good to go. Thanks!

@kit-ty-kate kit-ty-kate merged commit 147cfef into ocaml:master Feb 19, 2020
@tmattio
Copy link
Contributor Author

tmattio commented Feb 19, 2020

@kit-ty-kate Will do, thanks! Any reason for increaing the lower bound to 2.0?

@kit-ty-kate
Copy link
Member

@kit-ty-kate Will do, thanks! Any reason for increaing the lower bound to 2.0?

Because otherwise the compilation will fail with lower versions. You changed the lower-bound in this commit: tmattio/inquire@11e1c4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants