Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opam-installer with dune 2.5.0 #16180

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

kit-ty-kate
Copy link
Member

test if this happens to fix the issue encountered in #16170

cc @AltGr @rjbou

@camelus
Copy link
Contributor

camelus commented Apr 11, 2020

Commit: 9d634ad

Good to see you Madam.

🌤️ opam-lint warnings 9d634ad
  • opam-installer.2.0.2 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • opam-installer.2.0.3 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • opam-installer.2.0.4 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • opam-installer.2.0.5 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • opam-installer.2.0.6 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot

☀️ Installability check (+0)

@kit-ty-kate
Copy link
Member Author

kit-ty-kate commented Apr 11, 2020

Looks like it works. @AltGr @rjbou, are the use of make opam-<pkg>.install only to allow local pins with vendors libraries?

@kit-ty-kate kit-ty-kate marked this pull request as ready for review April 11, 2020 18:54
@kit-ty-kate kit-ty-kate merged commit 73b99f8 into ocaml:master Apr 11, 2020
@rjbou
Copy link
Contributor

rjbou commented Apr 14, 2020

Thanks @kit-ty-kate for this fix!
It was just a sed error, opam master fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants