Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove {build} flags from all ppx_* dependencies. #16278

Closed
wants to merge 1 commit into from

Conversation

paurkedal
Copy link
Contributor

This was suggested by @avsm in #11852, which had a more narrow scope addressing the specific issue with having ppx_sexp_conv as a build dependency. I agree with extending the scope, though we may want to discuss the approach before merging. I am not familiar with most of the packages involved, so what I have done here is to remove the {build} flag on every dependency on a package starting with ppx_*, as well as bisect_ppx and lwt_ppx, and hoping that the CI will catch any errors.

@paurkedal paurkedal force-pushed the make-ppx-non-build-deps branch from 782c571 to 26d386b Compare April 23, 2020 20:20
@camelus
Copy link
Contributor

camelus commented Apr 23, 2020

Commit: 26d386b

@paurkedal has posted 32 contributions.

🌤️ opam-lint warnings 26d386b
  • bitstring.3.1.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • bitstring.3.1.1 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • charrua-core.0.3 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • charrua-core.0.4 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • coq-serapi.8.7.1+0.4.1 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • coq-serapi.8.7.1+0.4.12 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • coq-serapi.8.7.1+0.4.2 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • coq-serapi.8.7.1+0.4.8 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • coq-serapi.8.7.1+0.4 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • flowtype.0.78.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • flowtype.0.79.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • flowtype.0.79.1 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • flowtype.0.80.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • mirage-nat.1.1.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ocveralls.0.3.2 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ocveralls.0.3.3 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ocveralls.0.3.4 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ppx_bitstring.1.3.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ppx_bitstring.1.3.1 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ppx_bitstring.1.3.2 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ppx_bitstring.1.3.3 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ppx_protocol_conv.0.9.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ppx_protocol_conv.1.0.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ppx_protocol_conv.2.0.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ssh-agent.0.1.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • These packages passed lint tests: alba.0.4.1, alba.0.4.2, amf.0.1.2, cconv-ppx.0.5, charrua-core.0.10, charrua-core.0.11.0, charrua-core.0.11.1, cohttp.1.0.2, cohttp.1.1.0, conduit.0.12.0, conduit.0.13.0, conduit.0.14.0, conduit.0.14.1, conduit.0.14.2, conduit.0.14.3, conduit.0.14.4, conduit.0.14.5, conduit.0.15.0, conduit.0.15.1, conduit.0.15.2, conduit.0.15.3, conduit.0.15.4, coq-serapi.8.10.0+0.7.0, coq-serapi.8.11.0+0.11.0, coq-serapi.8.9.0+0.6.0, coq-serapi.8.9.0+0.6.1, datakit-ci.0.12.2, datakit-ci.1.0.0, diet.0.1, easy_xlsx.1.0, flow_parser.0.80.0, lens.1.2.1, lens.1.2.2, lens.1.2.3, lwt.2.7.0, lwt.2.7.1, lwt.3.0.0, mirage-block-xen.1.6.1, mirage-block-xen.1.6.2, mirage-block-xen.1.7.0, mirage-nat.1.2.0, mirage-profile.0.9.0, mirage-profile.0.9.1, mmdb.0.1.0, mpris.0.2.0, mrt-format.0.3.1, mssql.1.1, netchannel.1.8.1, obeam.0.0.3, obeam.0.0.4, obeam.0.1.0, obeam.0.1.1, obeam.0.1.2, obeam.0.1.3, obeam.0.1.4, obeam.0.1.5, open_packaging.1.0, orewa.0.1.0, orewa.0.1.1, orewa.0.2.0, pcap-format.0.5.1, pgocaml.3.1, pgocaml.3.2, pgx.0.1, plotkicadsch.0.2.0, plotkicadsch.0.3.0, plotkicadsch.0.4.0, plotkicadsch.0.5.0, plotkicadsch.0.5.1, plotkicadsch.0.5.2, ppx_deriving_protobuf.2.7, ppx_deriving_protocol.0.8, ppx_deriving_yojson.3.3, ppx_deriving_yojson.3.4, ppx_deriving_yojson.3.5.1, ppx_deriving_yojson.3.5.2, ppx_deriving_yojson.3.5, ppx_hardcaml.1.0.0, ppx_regexp.0.3.0, protocol-9p-unix.0.12.1, protocol-9p.0.12.1, qcow-format.0.4.1, qcow-format.0.4.2, qcow-format.0.4, qcow-format.0.5.0, qcow.0.10.0, qcow.0.10.2, qcow.0.10.3, qcow.0.10.4, qcow.0.6.0, qcow.0.7.0, qcow.0.8.1, qcow.0.9.0, qcow.0.9.4, qcow.0.9.5, reed-solomon-erasure.1.0.1, reed-solomon-erasure.1.0.2, satyrographos.0.0.1.4, spreadsheetml.1.0, ssh-agent.0.2.0, ssh-agent.0.3.0, tar.1.0.0, tar.1.0.1, tar.1.1.0, teash.0.1.0, travesty.0.1.2, uri.2.1.0, uri.2.2.0, uri.2.2.1, vchan-xen.4.0.0, vchan-xen.4.0.1, vchan-xen.4.0.2, vhd-format.0.12.0


☀️ Installability check (+0)

@kit-ty-kate
Copy link
Member

It seems a bit too excessive to remove it for all ppx packages. It makes sense for ppx_sexp_lib however.

@avsm
Copy link
Member

avsm commented Apr 24, 2020

Why is it excessive? It’s strictly correct to do so — we simply don’t know what has changed in the library that may affect the code generation phase before.

@avsm
Copy link
Member

avsm commented Apr 24, 2020

I've started a discussion among the opam-repo maintainer team about this, and will update when we reach consensus.

@mseri
Copy link
Member

mseri commented Oct 20, 2020

I am going to close this for now, we will reopen and update it as soon as there is a consensus. Currently, it has got stale and would need rebasing anyways

@mseri mseri closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants