Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package lem.2020-06-03 #16567

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Conversation

tperami
Copy link
Contributor

@tperami tperami commented Jun 3, 2020

lem.2020-06-03

Lem is a tool for lightweight executable mathematics
Lem is a tool for lightweight executable mathematics, for writing,
managing, and publishing large-scale portable semantic definitions,
with export to LaTeX, executable code (currently OCaml) and
interactive theorem provers (currently Coq, HOL4, and Isabelle/HOL).

It is also intended as an intermediate language for generating
definitions from domain-specific tools, and for porting definitions
between interactive theorem proving systems.



🐫 Pull-request generated by opam-publish v2.0.2

@camelus
Copy link
Contributor

camelus commented Jun 3, 2020

Commit: ed23183

Hello @CuiCui66! I believe this is your first contribution here. Please be nice, reviewers!

☀️ All lint checks passed ed23183
  • These packages passed lint tests: lem.2020-06-03

☀️ Installability check (+1)
  • new installable packages (1): lem.2020-06-03

@tperami
Copy link
Contributor Author

tperami commented Jun 3, 2020

Do not merge

Actually I discovered some tests, (I'm just packaging, I did not write the software) and they don't pass, So I need to make them pass and then add them to the the target "with-test" in the opam file.

Should I close the PR and open another one when this is done, or should I leave it open?

@kit-ty-kate
Copy link
Member

if the version number gets change it might be easier to close it, otherwise you can let it open as opam-publish should be able to update the PR.

@tperami
Copy link
Contributor Author

tperami commented Jun 4, 2020

After discussing with an author, this was a legacy test suite that was not updated for several years and is not valid anymore. It's normal they fail. They are not even mentioned in the README or anything else. The main test suite is already invoked by the main make invocation and pass. We'll keep them in case someone updates them later but they will not be run by the opam with-test variable as they are not correct anymore.

@kit-ty-kate In the end, we can merge the PR as-is

@Alasdair Alasdair mentioned this pull request Jun 4, 2020
@tperami tperami mentioned this pull request Jun 4, 2020
@avsm avsm merged commit 9509aa5 into ocaml:master Jun 6, 2020
@avsm
Copy link
Member

avsm commented Jun 6, 2020

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants