Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tezos compatibility with uri 4.0 #17429

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Fix tezos compatibility with uri 4.0 #17429

merged 2 commits into from
Oct 20, 2020

Conversation

pirbo
Copy link
Contributor

@pirbo pirbo commented Oct 18, 2020

Uri 4.0 dropped (well separate into a new package) its dependency to re.

That revealed that, in 2 places in tezos, re is used without being explicitly declared in the dune files which now led build failure. These patches fix that.

@camelus
Copy link
Contributor

camelus commented Oct 18, 2020

Commit: 21199e0

@pirbo has posted 39 contributions.

☀️ All lint checks passed 21199e0
  • These packages passed lint tests: tezos-base.7.4, tezos-clic.7.4, tezos-stdlib-unix.7.4

☀️ Installability check (+0)

🌤️ 2 ignored non-opam files:
  • packages/tezos-clic/tezos-clic.7.4/files/with-re.patch
  • packages/tezos-stdlib-unix/tezos-stdlib-unix.7.4/files/with-re.patch

@avsm
Copy link
Member

avsm commented Oct 19, 2020

Interesting, thanks for the fix. This sort of transitive dependency issue is difficult to spot in testing, but we've got ocurrent/ocaml-ci#257 open to see if we can simulate it better. Dune also supports implicit_transitive_deps and there are a few open PRs to improve the usability of this ocaml/dune#2733.

@avsm
Copy link
Member

avsm commented Oct 19, 2020

Note that tezos does not show up in the reverse dep list for uri at all: https://ci.ocaml.org/ocaml/opam-repository/pr/17411?history=7282de3706ca1661102d7ef80353bfe9db5a3822&test=2%20Revdeps

@mseri
Copy link
Member

mseri commented Oct 19, 2020

In general I would have asked to move the change to a patch release but the packages are all version-linked and that would require a full release. So in this case I am in favour of making an exception an merge the patch. @kit-ty-kate do you agree?

@mseri mseri merged commit 7ce73dd into ocaml:master Oct 20, 2020
@pirbo pirbo deleted the uri4-tezos branch May 14, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants