Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam-monorepo.0.1.0 requires dune >= 2.7 #17811

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

emillon
Copy link
Contributor

@emillon emillon commented Dec 11, 2020

It vendors its dependencies, including dune 2.7 (for dune libraries), so it needs a dune that can interpret (lang dune 2.7).

It vendors its dependencies, including dune 2.7 (for dune libraries), so
it needs a dune that can interpret `(lang dune 2.7)`.
@emillon
Copy link
Contributor Author

emillon commented Dec 11, 2020

cc @NathanReb, you'll want to sync the opam file in the project as well.

@mseri mseri merged commit 2b1ae7d into ocaml:master Dec 11, 2020
@mseri
Copy link
Member

mseri commented Dec 11, 2020

@Emilion thanks! dune should probably also fail in this case. Can you open an issue there?

@emillon
Copy link
Contributor Author

emillon commented Dec 11, 2020

Do you mean, it should generate a bound compatible with all subprojects? sure!

@camelus
Copy link
Contributor

camelus commented Dec 11, 2020

Commit: 5157671

A pull request by opam-seasoned @emillon.

☀️ All lint checks passed 5157671
  • These packages passed lint tests: opam-monorepo.0.1.0

☀️ Installability check (+0)

@mseri
Copy link
Member

mseri commented Dec 11, 2020

Yes! Thank you very much

@emillon
Copy link
Contributor Author

emillon commented Dec 21, 2020

@mseri done in ocaml/dune#4051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants