Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] jsonxt (1.0.0) #18723

Merged
merged 1 commit into from
Jun 1, 2021
Merged

[new release] jsonxt (1.0.0) #18723

merged 1 commit into from
Jun 1, 2021

Conversation

stevebleazard
Copy link
Contributor

Jsonxt - JSON parsers for files, strings and more

CHANGES:
  • Initial release

@kit-ty-kate
Copy link
Member

The tests segfault on ppc64:

# Test Successful in 0.120s. 488 tests run.
#     jxtester alias tests/core/run_test_suite_all (got signal SEGV)

@avsm
Copy link
Member

avsm commented May 25, 2021

ppc64 has sometimes strange requirements with C bindings. Restricting this to arch != ppc64 is fine to merge to opam-repo

CHANGES:

- Initial release
@stevebleazard
Copy link
Contributor Author

ppc64 has sometimes strange requirements with C bindings. Restricting this to arch != ppc64 is fine to merge to opam-repo

I added 'available: [arch != "ppc64"]' to jsonxt.opam and a bunch of opam 2.1 compiles failed with m4 missing. It's not clear why

@kit-ty-kate
Copy link
Member

I added 'available: [arch != "ppc64"]' to jsonxt.opam and a bunch of opam 2.1 compiles failed with m4 missing. It's not clear why

Sorry that's totally my fault. I've fixed the issue and the rest seems all good. Thanks!

@kit-ty-kate kit-ty-kate merged commit b1afcb2 into ocaml:master Jun 1, 2021
@kit-ty-kate
Copy link
Member

kit-ty-kate commented Jun 1, 2021

@stevebleazard Actually it seems I've merged that too fast. I've just tested locally but it looks like your package infinit-loops when using OCaml 4.11 here:

$ dune build --verbose -j 1
[...]
Running[210]: (cd _build/default && /home/kit_ty_kate/.opam/4.11/bin/ocamlc.opt -w @1..3@5..28@30..39@43@46..47@49..57@61..62-40 -strict-sequence -strict-formats -short-paths -keep-locs -g -bin-annot -I lib/.jsonxt.objs/byte -intf-suffix .ml -no-alias-deps -opaque -open Jsonxt__ -o lib/.jsonxt.objs/byte/jsonxt__Utilities.cmo -c -impl lib/utilities.ml)

I'll fix your package constraint but you might want to look into that.

@stevebleazard
Copy link
Contributor Author

@kit-ty-kate Thanks, I will take a look at 4.11, I suspect I've seen this type of issue before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants