Change all dune subst {pinned} into dune subst {dev} #18732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine to just merge, rather than holding it open and the conflicts growing. It also doesn't introduce a semantic change into the packages beyond fixing a bug (the specific case of a pinned archive will change), so no version bump for the packages is required. |
|
I vote for merging this fast |
|
I've eyeballed the diff and it looks fine. Merging, thanks @kit-ty-kate ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a mistaken guideline/autogeneration in jbuilder/dune until dune 2.7. See ocaml/dune#3647
This is a draft for now as it will make everyone rebuild their packages but it might be worth doing it at some point if only to give a good example.