Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax bounds to prepare MirageOS 4 #19754

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

samoht
Copy link
Member

@samoht samoht commented Oct 12, 2021

The goal is to upstream some of the changes available in https://github.com/mirage/mirage-dev

@samoht
Copy link
Member Author

samoht commented Oct 12, 2021

mirage-crypto-pk test doesn't seem to pass on 32 bits machines:

# ==============================================================================
# Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:2:selftest.
# 
# File "/home/opam/.opam/4.12/.opam-switch/build/mirage-crypto-pk.0.10.3/_build/default/tests/oUnit-All-builder#00.log", line 2489, characters 1-1:
# Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:2:selftest (in the log).
# 
# Worker stops running: Killed by signal -22
# ------------------------------------------------------------------------------
# ==============================================================================
# Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:1:selftest.
# 
# File "/home/opam/.opam/4.12/.opam-switch/build/mirage-crypto-pk.0.10.3/_build/default/tests/oUnit-All-builder#00.log", line 2385, characters 1-1:
# Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:1:selftest (in the log).
# 
# Worker stops running: Killed by signal -22
# ------------------------------------------------------------------------------
# ==============================================================================
# Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:0:selftest.
# 
# File "/home/opam/.opam/4.12/.opam-switch/build/mirage-crypto-pk.0.10.3/_build/default/tests/oUnit-All-builder#00.log", line 2359, characters 1-1:
# Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:0:selftest (in the log).
# 
# Worker stops running: Killed by signal -22
# ------------------------------------------------------------------------------
# Ran: 359 tests in: 8.29 seconds.
# FAILED: Cases: 359 Tried: 359 Errors: 3 Failures: 0 Skip:  0 Todo: 0 Timeouts: 0.

@samoht
Copy link
Member Author

samoht commented Oct 12, 2021

And solo5-bindings-hvt doesn't seem to compile on the CI:

#=== ERROR while compiling solo5-bindings-hvt.0.6.4 ===========================#
# context              2.0.9 | linux/x86_64 | ocaml-base-compiler.4.05.0 | file:///home/opam/opam-repository
# path                 ~/.opam/4.05/.opam-switch/build/solo5-bindings-hvt.0.6.4
# command              ~/.opam/opam-init/hooks/sandbox.sh build ./configure.sh
# exit-code            1
# env-file             ~/.opam/log/solo5-bindings-hvt-172-a6f66d.env
# output-file          ~/.opam/log/solo5-bindings-hvt-172-a6f66d.out
### output ###
# configure.sh: ERROR: Only 'gcc' 4.x+ is supported on Linux

Is this a missing conf-gcc dependency?

@dinosaure
Copy link
Contributor

Indeed for mirage-crypto, I will try find a fix on it. For Solo5, conf-gcc is indeed required.

@samoht
Copy link
Member Author

samoht commented Oct 12, 2021

conf-gcc added in #19755

@samoht samoht force-pushed the relax-bounds-mirage4 branch from 1dc4b59 to 93e439f Compare October 13, 2021 08:05
```
 ==============================================================================
 Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:2:selftest.

 File "/home/opam/.opam/4.12/.opam-switch/build/mirage-crypto-pk.0.10.3/_build/default/tests/oUnit-All-builder#00.log", line 2489, characters 1-1:
 Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:2:selftest (in the log).

 Worker stops running: Killed by signal -22
 ------------------------------------------------------------------------------
 ==============================================================================
 Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:1:selftest.

 File "/home/opam/.opam/4.12/.opam-switch/build/mirage-crypto-pk.0.10.3/_build/default/tests/oUnit-All-builder#00.log", line 2385, characters 1-1:
 Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:1:selftest (in the log).

 Worker stops running: Killed by signal -22
 ------------------------------------------------------------------------------
 ==============================================================================
 Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:0:selftest.

 File "/home/opam/.opam/4.12/.opam-switch/build/mirage-crypto-pk.0.10.3/_build/default/tests/oUnit-All-builder#00.log", line 2359, characters 1-1:
 Error: All:3:RSA:3:RSA-OAEP(SHA1)-ENC:0:selftest (in the log).

 Worker stops running: Killed by signal -22
 ------------------------------------------------------------------------------
 Ran: 359 tests in: 8.29 seconds.
 FAILED: Cases: 359 Tried: 359 Errors: 3 Failures: 0 Skip:  0 Todo: 0 Timeouts: 0.
```
@samoht
Copy link
Member Author

samoht commented Oct 13, 2021

I've disabled mirage-crypto-pk on arm32 - the rest of the errors are not fixable (unless we could have a conf-gcc<10 kind of package)

@samoht samoht merged commit baa76db into ocaml:master Oct 13, 2021
@hannesm
Copy link
Member

hannesm commented Oct 13, 2021

I've disabled mirage-crypto-pk on arm32

please don't do that. it has been ported to arm32, there is a CI that works on arm32 in the mirage-crypto repository. why your PR leads to "signal -22" here is really not clear to me, since the last release of mirage-crypto to opam-repository also lead to a successful CI.

please revert that change. thanks.

@hannesm
Copy link
Member

hannesm commented Oct 13, 2021

see #19689 (comment) for another discussion about "error -22". please investigate what the underlying issue is with the CI system in place, and report an issue to the mirage-crypto repository instead of marking it as unavailable on some architectures. mirage-crypto is working on 32 bit platforms fine since 0.7.0.

@samoht
Copy link
Member Author

samoht commented Oct 13, 2021

Done in #19764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants