Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] mrmime (0.5.0) #19801

Merged
merged 7 commits into from
Oct 26, 2021
Merged

Conversation

dinosaure
Copy link
Contributor

Mr. MIME

CHANGES:

CHANGES:

- Replace deprecated functions of `fmt` library (@dinosaure, mirage/mrmime#86)
- Fix OPAM constraints (@kit-ty-kate, @dinosaure, mirage/mrmime#85)
- Clarify the semantic about the underlying quoted-printable encoder (@dinosaure, mirage/mrmime#84)
- Be able to pass the seed to generate the boundary (@dinosaure, mirage/mrmime#83)
- Let the user to decide if it wants to encode or not the given stream
  according to the `Content-Transfer-Encoding` (@dinosaure, mirage/mrmime#82)
- Add `Content_type.Type.of_string` (@dinosaure, mirage/mrmime#81)
- Add `Header.add_unless_exists` (@dinosaure, mirage/mrmime#81)
- Add a regression test about mirage/mrmime#77 (@lyrm, @dinosaure, mirage/mrmime#78)
- Fix bug on the Base64 decoder (@clecat, @lyrm, @dinosaure, mirage/mrmime#78)
- Don't try to split quoted-printable and add useless spaces to respect isomorphism (@dinosaure, @lyrm, mirage/mrmime#77)
- Fix how we escape `\b` in content-type parameters (@dinosaure, mirage/mrmime#73)
- Add `Header.{length,to_list,of_list,to_list_with_location}` (@dinosaure, mirage/mrmime#72)
- Enable `fws` token in quoted-string values (as a parameter of the content-type) (@lyrm, @dinosaure, mirage/mrmime#71)
- Handle correctly an empty part with `angstrom` (@dinosaure, mirage/mrmime#68)
- Generate a corpus of a million emails where we ensure that
  `mrmime` assumes a kind of _isomorphism_, see https://github.com/mirage/hamlet
  for more details (@lyrm, @dinosaure, mirage/mrmime#67)
- Fix some comparison functions (on IANA values and field-name) (@lyrm, @dinosaure, mirage/mrmime#66)
- Simplify the `Mail.t` type (@lyrm, @dinosaure, mirage/mrmime#63)
- Fix pattern-matching failure when decoder is closed (@dinosaure, mirage/mrmime#62)
- Keep the order of fields into a header when we replace one (@dinosaure, mirage/mrmime#61)
- Ensure stable memory with lwt when we parse contents (@dinosaure, mirage/mrmime#60)
- Fix how we parse quoted-printable contents (@dinosaure, mirage/mrmime#59)
- Add a space in front of any field's values (@dinosaure, mirage/mrmime#56)
- Ensure to emit only lines (@dinosaure, mirage/mrmime#55)
- Fix how we parse Content-Transfer-Encoding (@dinosaure, mirage/mrmime#54)
- Better pretty-print multiple domains on mailbox (@dinosaure, mirage/mrmime#53)
- Unlock the arbitrary limit on the internal buffer to decode the header (@dinosaure, mirage/mrmime#51)
- Delete unused phrases field value (@dinosaure, mirage/mrmime#50)
- Fix fuzzer (@dinosaure, mirage/mrmime#49)
@mseri
Copy link
Member

mseri commented Oct 19, 2021

Current failures are due to GitHub responding wit 403 to the tarball requests, this is going on since a couple of days now also outside the CI

@kit-ty-kate
Copy link
Member

@dinosaure I'm not sure to understand the changes to dkim. The constraints are changed in a way too tight manner and will break users that need earlier versions. Are all the new lower-bound constraints really always required, what were the issues?

@dinosaure
Copy link
Contributor Author

@dinosaure I'm not sure to understand the changes to dkim. The constraints are changed in a way too tight manner and will break users that need earlier versions. Are all the new lower-bound constraints really always required, what were the issues?

I don't think that at this stage someone uses dkim. It seems too tight but the first release of dkim was not done with the lower bounds check. So I do such lint now (and, of course, it breaks an usage of dkim but as I said, nobody really use it).

I think, for the purpose of the release, it's fine when I have the ownership on this dependencies path. Note that, after that, I will be able to make an other release of dkim.

@samoht samoht merged commit d9f0499 into ocaml:master Oct 26, 2021
@samoht
Copy link
Member

samoht commented Oct 26, 2021

The CI is broken for an unrelated reason:

(analysis) (failed: "packages/dkim/dkim.0.1.0/opam" failed to be parsed: while expecting opam-file: Sys_error("No such file or directory") -- Raised by primitive operation at OpamSystem.real_path in file "src/core/opamSystem.ml", line 343, characters 55-70 Called from OpamFilename.of_string in file "src/core/opamFilename.ml", line 181, characters 15-36 Called from OpamFormat.I.file.(fun) in file "src/format/opamFormat.ml", line 609, characters 9-46 Called from OpamPp.(-|).(fun) in file "src/format/opamPp.ml", line 116, characters 14-30 Called from OpamPp.(-|).(fun) in file "src/format/opamPp.ml", line 116, characters 14-30 Called from OpamPp.parse in file "src/format/opamPp.ml", line 91, characters 26-41 )

so merging.

"digestif" {>= "0.9.0"}
"base-unix"
"hmap"
"domain-name"
"dns-client" {< "5.0.0"}
"dns-client" {>= "4.6.3" & < "5.0.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dns 4.6.3 did not exist at the time of release of dkim.0.1.0. Could you revert this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants