Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] xdg, stdune, ordering, fiber, dyn, dune, dune-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.0) #20721

Closed
wants to merge 8 commits into from
Closed

[new release] xdg, stdune, ordering, fiber, dyn, dune, dune-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.0) #20721

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f41000a
[new release] xdg, stdune, ordering, fiber, dyn, dune, dune-site, dun…
rgrinberg Feb 11, 2022
6b80665
xdg.3.0.0: Add missing constraint (uses -alert)
kit-ty-kate Feb 15, 2022
3e87eb2
dune-build-info.3.0.0: Add missing constraint (uses -alert)
kit-ty-kate Feb 15, 2022
305a231
dune-action-plugin.3.0.0: Fix constraint
kit-ty-kate Feb 15, 2022
f2f4d63
dune-rpc-lwt.3.0.0: Add/Fix missing constraints
kit-ty-kate Feb 15, 2022
b0bf1a7
dune-configurator.3.0.0: Fix constraints
kit-ty-kate Feb 15, 2022
3eccf7a
stdune.3.0.0: Add missing constraints
kit-ty-kate Feb 15, 2022
aee5414
dune.3.0.0 is incompatible with base-effects
kit-ty-kate Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/dune-rpc-lwt/dune-rpc-lwt.3.0.0/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ doc: "https://dune.readthedocs.io/"
bug-reports: "https://github.com/ocaml/dune/issues"
depends: [
"dune" {>= "3.0"}
"result"
"result" {>= "1.5"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kit-ty-kate where did this constraint come from? I think I can actually just remove this dependency. We don't use the result package at all anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh never mind. We require it because of Lwt.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was just a guess, given anything below 1.5 doesn’t have compatible types with the standard library (Result.t != Stdlib.Result.t)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it won’t be the case in Lwt 5.6.0: ocsigen/lwt#925

"dune-rpc" {= version}
"csexp" {>= "1.4.0"}
"lwt"
"csexp" {>= "1.5.0"}
"lwt" {>= "5.3.0"}
"odoc" {with-doc}
]
dev-repo: "git+https://github.com/ocaml/dune.git"
Expand Down