Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.7.2 (2022-05-27)
test_zeropage
(@felixmoebius, dependency fixes #515)mem_size
uniformly viaXENMEM_memory_map
hypercall.Previously, the memory map was extracted from the HVM start info (if
available and booting directly via PVH), or multiboot info (if booting via
multiboot). The fallback for direct PVH booting was the
XENMEM_memory_map
hypercall (which retrieves an E820 memory map). This lead to three distinct
paths, with no fallback for the memory map not being present in the multiboot
info. With QubesOS 4.1 (Xen 4.14), this didn't work anymore (it worked with
QubesOS 4.0 (Xen 4.8)).
Now, there is a single path of the code, which uses the hypercall. Since this
is only executed once at startup, the overhead is negligible (@hannesm, consistently use %{make}% instead of "make" in opam invocations. #516,
review and discussions with @marmarek @xaki23 @palainp)
This code originated from the virtio binding, but when booting on xen via
multiboot there is no additional token.
(@hannesm, New ocp indent #517, review and testing with @palainp @xaki23)