Fix ocaml-base-compiler.5.0.0~beta1 on bytecode-only architectures
#22246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaml-options-vanilla now pulls in the ocaml-option-bytecode-only iff OCaml 5 must compile without the native compiler.
kit-ty-kate
reviewed
Oct 12, 2022
| ocaml-base-compiler:version < "5" | | ||
| ocaml-variants:version < "5" | | ||
| arch = "arm64" | | ||
| arch = "x86_64" } |
There was a problem hiding this comment.
😭 this is going to make everyone rebuild all of their switches if they have opam < 2.2 😭
There was a problem hiding this comment.
Doesn't that mean that every new supported architecture on OCaml 5 will trigger such a rebuild ?
There was a problem hiding this comment.
yes, any change in the depends field with opam < 2.2 triggers a rebuild
There was a problem hiding this comment.
ah it looks like since these are post dependencies it might be fine in the end. From quick testing:
- opam 2.0 does not do anything
- opam 2.1 does reinstall just ocaml-options-vanilla
- opam 2.2 does nothing
But i suppose it requires more testing to be sure
|
Thanks |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the present version of
ocaml-base-compiler.5.0.0~beta1to install. I'm tempted to say we should remove the dependency onocaml-option-bytecode-onlyinstead until we finally decide to merge the+optionspackage andocaml-base-compilerinto 1.ocaml-base-compiler.5.0.0~beta1pulls in the bytecode-only package and doesn't allow its removalocaml-base-compiler.5.0.0~beta1doesn't pull inocaml-option-bytecode-onlyand it can't be added to the switchocaml-base-compiler.4.14.0likewise doesn't pull in the package and doesn't allow its installationocaml-base-compiler.4.14.0likewise doesn't pull in the package and doesn't allow its installation