Add build field to XML-Light 2.4
#23369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current instructions are missing a `build` field (that `xml-light.2.3` has). It works because the `install` field uses the `install_ocamlfind` target which depends on `all` and `opt` but it seems a bit inelegant to build in the `install` step. This was detected as opam-monorepo classifies packages without `build` instructions as packages without a source, which is not the case for `xml-light`. A PR exists tarides/opam-monorepo#376 but there is the question whether missing `build` steps is a packaging mistake or not. In any case, this PR is a proposal to fix the issue and I'm looking forward to hear the input of opam-repository maintainers on this question.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current instructions are missing a
buildfield (thatxml-light.2.3has). It works because theinstallfield uses theinstall_ocamlfindtarget which depends onallandoptbut it seems a bit inelegant to build in theinstallstep.This was detected as opam-monorepo classifies packages without
buildinstructions as packages without a source, which is not the case forxml-light. A PR existstarides/opam-monorepo#376 but there is the question whether missing
buildsteps is a packaging mistake or not.In any case, this PR is a proposal to fix the issue and I'm looking forward to hear the input of opam-repository maintainers on this question.