[new release] lwt_eio (0.4) #24304
Merged
[new release] lwt_eio (0.4) #24304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Get Lwt and Eio to share the SIGCHLD handler (@talex5 ocaml-multicore/lwt_eio#19). Otherwise, Lwt replaces Eio's handler and may prevent Eio from noticing child processes finishing. - Don't allow cancelling things after forking (@talex5 ocaml-multicore/lwt_eio#21). With io_uring, this will mess up the parent's ring. - Add `Lwt_eio.run_lwt_in_main` (@talex5 ocaml-multicore/lwt_eio#20). This is useful if your program uses multiple Eio domains and you want to run some Lwt code from any of them. - Fix some Eio deprecation warnings (@talex5 ocaml-multicore/lwt_eio#18).
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Lwt code within Eio
CHANGES:
Get Lwt and Eio to share the SIGCHLD handler (@talex5 Get Lwt and Eio to share the SIGCHLD handler ocaml-multicore/lwt_eio#19).
Otherwise, Lwt replaces Eio's handler and may prevent Eio from noticing child processes finishing.
Don't allow cancelling things after forking (@talex5 Don't allow cancelling things after forking ocaml-multicore/lwt_eio#21).
With io_uring, this will mess up the parent's ring.
Add
Lwt_eio.run_lwt_in_main(@talex5 Add Lwt_eio.run_lwt_in_main ocaml-multicore/lwt_eio#20).This is useful if your program uses multiple Eio domains and you want to run some Lwt code from any of them.
Fix some Eio deprecation warnings (@talex5 Update to Eio 0.10 ocaml-multicore/lwt_eio#18).