-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cloudi.2.0.7 #24689
Added cloudi.2.0.7 #24689
Conversation
Only |
Strange, gmp should be there. I think homebrew uses a different path on arm, maybe the build script is looking in the wrong place |
@mseri The failure occurs in the I added big integer support to the Erlang External Term Format implementation used by this source code when OCaml still included big integer support with I would like to think that zarith could be a part of OCaml in the future, but the current OCaml direction appears to consider big integer use as unimportant for OCaml use. |
Thanks! |
Perhaps I was too fast here at merging. What is the point of requiring zarith but also vendoring it? |
@mseri The approach is intentional to catch problems early and improve the in-place compilation in the main repository (https://github.com/CloudI/CloudI/tree/develop/src/api/ocaml) as necessary. Using this approach, there is always the assurance that the build of the OCaml CloudI API is the same as in the main repository. |
depends: [ | ||
"ocaml" {>= "4.03.0"} | ||
"base-unix" | ||
"zarith" {>= "1.13"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case you don't really need this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it might not be strictly necessary, I wanted to be transparent about the dependency on zarith, so it appears in the cloudi package information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification
No description provided.