-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] mustache (3.2.0) #24839
Conversation
bbec1ee
to
c00f813
Compare
Investigating the devreps breaking to see if it's expected or needs fixing:
It's expected: rgrinberg/ocaml-mustache@bf3ad00 Will add the upper bound in soupalt |
159be3a
to
3322429
Compare
All revdeps pass, all the failures left are due to soupault, unrelated to mustache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me except for the tiny cosmetic change suggested.
All CI failures are unrelated to this PR as stated in #24839 (comment)
All revdeps pass, all the failures left are due to soupault, unrelated to mustache
"Gabriel Scherer <gabriel.scherer@gmail.com>" | ||
] | ||
license: "MIT" | ||
homepage: "https://github.com/rgrinberg/ocaml-mustache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(triage note) it seems that the doc link (http://rgrinberg.github.io/mustache/
) is removed. it's likely intentional since the link is now 404
3322429
to
5c0c035
Compare
@psafont can you remove the bound on soupault? I think Re was transitively inherited from some other package. I will look into that separately |
I added the bound because this version of mustache has breaking changes and breaks those versions of soupault. Is this not standard practise anymore? |
CHANGES: * Remove the AST without locations: now all functions build an AST with locations; in particular, parsing always provide located error messages. To ease backward-compatibility, the smart constructors still use the same interface, using dummy locations by default, with a With_locations module for users who wish to explicitly provide locations. (@gasche, rgrinberg/ocaml-mustache#65) * Support for "template inheritance" (partials with parameters) `{{<foo}} {{$param1}}...{{/param1}} {{$param2}}...{{/param2}} {{/foo}` following the widely-implemented semi-official specification mustache/spec#75 (@gasche, 58) * Partials are now supported in the `mustache` command-line tool (@gasche, rgrinberg/ocaml-mustache#57) They are interpreted as template inclusion: "{{>foo/bar}}" will include "foo/bar.mustache", relative to the current working directory. * Improve error messages (@gasche, rgrinberg/ocaml-mustache#47, rgrinberg/ocaml-mustache#51, rgrinberg/ocaml-mustache#56) Note: the exceptions raised by Mustache have changed, this breaks compatibility for users that would catch and deconstruct existing exceptions. * Add `render_buf` to render templates directly to buffers (@gasche, rgrinberg/ocaml-mustache#48) * When a lookup fails in the current context, lookup in parents contexts. This should fix errors when using "{{#foo}}" for a scalar variable 'foo' to check that the variable exists. (@gasche, rgrinberg/ocaml-mustache#49)
mustache 3.2.0 contains breaking changes
5c0c035
to
480c69d
Compare
Oh sorry for wasting your time and thanks. I thought it was for the Re failure in the lower bounds, my bad. I will add them back manually. |
I had the changeset prepared just in case ;) |
Thanks a lot! |
Mustache logic-less templates in OCaml
CHANGES:
in particular, parsing always provide located error messages.
To ease backward-compatibility, the smart constructors still use the
same interface, using dummy locations by default, with
a With_locations module for users who wish to explicitly provide
locations.
(@gasche, Remove the ast without locations rgrinberg/ocaml-mustache#65)
{{<foo}} {{$param1}}...{{/param1}} {{$param2}}...{{/param2}} {{/foo}
following the widely-implemented semi-official specification
Add template inheritance spec mustache/spec#75
(@gasche, 58)
mustache
command-line tool (@gasche, have partials interpreted as template inclusion in mustache_cli rgrinberg/ocaml-mustache#57)They are interpreted as template inclusion: "{{>foo/bar}}" will include
"foo/bar.mustache", relative to the current working directory.
Note: the exceptions raised by Mustache have changed, this breaks
compatibility for users that would catch and deconstruct existing
exceptions.
render_buf
to render templates directly to buffers (@gasche,render
functions: render in a buffer rgrinberg/ocaml-mustache#48)This should fix errors when using "{{#foo}}" for a scalar variable
'foo' to check that the variable exists.
(@gasche, when lookup fail in the current context, go to parent contexts rgrinberg/ocaml-mustache#49)