Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctypes 0.22.0 #25229

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add ctypes 0.22.0 #25229

merged 2 commits into from
Feb 19, 2024

Conversation

yallop
Copy link
Member

@yallop yallop commented Feb 10, 2024

No description provided.

@mseri
Copy link
Member

mseri commented Feb 16, 2024

There are lots of failures of the form

(failed: Library "ctypes.foreign" not found.)

is there a change that made these appeari with this release?

@mseri mseri added the question label Feb 16, 2024
@yallop
Copy link
Member Author

yallop commented Feb 17, 2024

Ah, we also need a new corresponding release of ctypes-foreign 0.22.0 (which I've just pushed in 6d72e1f), since the relationship between the two packages changed in the last release (#24101).

@raphael-proust
Copy link
Collaborator

The CI looks better although I don't understand some of the issues and so I can't tell for sure if they are from ctypes or from the revdeps being broken. I can tell that:

  • ppx_rapper seems broken (some expect test is failing) (ping @roddyyaga )
  • srt seems broken (missing dependency to ocamlfind?) (ping @toots )

@mseri
Copy link
Member

mseri commented Feb 19, 2024

I think they are both unrelated. For the first I don't think we can do anything (and seems to have to do more with ppx/ppxlib) and the latter is indeed likely a missing dependency that perhaps was transitive before (I'll send a PR to fix it)

@mseri
Copy link
Member

mseri commented Feb 19, 2024

I am more worried about macos failures:

# File "tests/test-callback_lifetime/dune", line 2, characters 7-29:
# 2 |  (name test_callback_lifetime)
#            ^^^^^^^^^^^^^^^^^^^^^^
# (cd _build/default/tests/test-callback_lifetime && ./test_callback_lifetime.exe)
# ..EE..
# ==============================================================================
# Error: Callback lifetime tests:3:calling expired closures (stubs).
# 
# File "/Users/mac1000/.opam/5.1.1/.opam-switch/build/ctypes-foreign.0.22.0/_build/default/tests/test-callback_lifetime/oUnit-Callback lifetime tests-m1-worker-01#00.log", line 55, characters 1-1:
# Error: Callback lifetime tests:3:calling expired closures (stubs) (in the log).
# 
# Worker stops running: Killed by signal -10
# ------------------------------------------------------------------------------
# ==============================================================================
# Error: Callback lifetime tests:2:calling expired closures (foreign).
# 
# File "/Users/mac1000/.opam/5.1.1/.opam-switch/build/ctypes-foreign.0.22.0/_build/default/tests/test-callback_lifetime/oUnit-Callback lifetime tests-m1-worker-01#00.log", line 51, characters 1-1:
# Error: Callback lifetime tests:2:calling expired closures (foreign) (in the log).
# 
# Worker stops running: Killed by signal -10
# ------------------------------------------------------------------------------
# Ran: 6 tests in: 1.36 seconds.
# FAILED: Cases: 6 Tried: 6 Errors: 2 Failures: 0 Skip:  0 Todo: 0 Timeouts: 0.

Are those known/expected?

@yallop
Copy link
Member Author

yallop commented Feb 19, 2024

The test_callback_lifetime failure on macOS is (unfortunately) a known issue: yallop/ocaml-ctypes#730

@toots
Copy link
Contributor

toots commented Feb 19, 2024

Glad to see that ctypes is being migrated to dune! I believe srt should be fine with a dependency on ocamlfind indeed. I have added it to the upstream repository so it'll be there for the next release.

@mseri mseri merged commit 05c3866 into ocaml:master Feb 19, 2024
1 of 2 checks passed
@yallop yallop deleted the ctypes-0.22.0 branch February 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants