Add Visual Studio conf packages (conf-msvc32.1, conf-msvc64.1, msvs-detect.0.7.0) #25440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvs-detect is taken from the msvs-tools project. This package simply installs two scripts to the share directory to be used by other packages.
These packages can only be installed if a suitable Visual Studio installation containing the Microsoft C compiler and macro assembler can be found. The two packages use msvs-detect to construct a .config file containing the required environment variable changes necessary to make this compiler available. These variables can then be used in the build-env or setenv fields of dependent packages. Both packages can be installed simultaneously; dependent packages are required to ensure that only one toolchain is actually in the environment at any given time. The packages fail to install if a compiler cannot be found - opam presently lacks an expressive enough depext system to be able to do anything further.
This is wonderfully appropriate for a Windows PR, coming straight from the Windows API school of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages are used as part of my proposal for packaging the MSVC port of OCaml in opam-repository, but the packages themselves are entirely independent.
msvs-detectpackages two scripts from metastack/msvs-tools which are then used byconf-msvc32.1andconf-msvc64.1.The two conf- packages can be simultaneously installed. They provide environment settings which can then be used by other packages, either in
build-envorsetenv: