Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ppx_deriving (6.0.1) #25689

Closed
wants to merge 2 commits into from

Conversation

NathanReb
Copy link
Contributor

CHANGES:

* Fix the unintentional removal of `Ppx_deriving_runtime.Result` in ocaml-ppx/ppx_deriving#279
  ocaml-ppx/ppx_deriving#282
  (@NathanReb)
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
@NathanReb
Copy link
Contributor Author

From a quick look it seems that none of the errors are related to ppx_deriving!

@NathanReb
Copy link
Contributor Author

If there is anything I can do to help the release go through, please let me know!

@mseri
Copy link
Member

mseri commented Apr 25, 2024

Are you sure that stitch, sihl, pkcs and pa_ppx failures are not related to this release (or to 6.0.0)? They all seem new

@NathanReb
Copy link
Contributor Author

I think pa_ppx might be yes, I ran into similar breakage with #25720.

I'll look into the others and report back!

@NathanReb
Copy link
Contributor Author

NathanReb commented Apr 26, 2024

stitch, pkcs and sihl were indeed legit failures from a bug I introduced in ocaml-ppx/ppx_deriving#281. I submitted a fix in ocaml-ppx/ppx_deriving#285.

I'll have to cancel this release as well. I'll be more careful next time and will follow the same course as for #25720 and attempt a draft release first.

I'll still look into pa_ppx before closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants