Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dream-encoding (0.3.0) #26847

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

tmattio
Copy link
Contributor

@tmattio tmattio commented Nov 8, 2024

Encoding primitives for Dream

CHANGES:

CHANGES:

- Discard encoding with priority 0 (tmattio/dream-encoding#3 by @samoht)
- Use a sub_log and log at debug level (tmattio/dream-encoding#2 by @beajeanm)
@mseri
Copy link
Member

mseri commented Nov 8, 2024

The failure with ocaml 5.3 is due to dream-httpaf failing to build, I think this should not block this merge, but I wanted to double check with you. You don't use compiler libs right?

@shonfeder
Copy link
Contributor

I think this is just waiting on clarification from @tmattio to decide whether we merge as is or not. :)

@samoht
Copy link
Member

samoht commented Nov 14, 2024

https://github.com/tmattio/dream-encoding/blob/main/lib/dune <- this doesn't use compiler-libs

@mseri
Copy link
Member

mseri commented Nov 15, 2024

Thanks

@mseri mseri merged commit dfecc46 into ocaml:master Nov 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants