avoid mirage-* packages that require solo5-bindings-* which are deprecated #27063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #23697 |
|
I know that they are equivalent, but why not "deprecated" instead? This way it will be easier to spot it for cleanup. (Sorry for not mentioning it in the other PR) The inconvenience with |
|
as you wish :) |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still on the fence, we could as well mark these as unavailable. They are bitrot, and requires solo5-bindings-* packages which are deprecated (and modern C compilers error compiling them due to usage of
-Wall -Werror.The list in here is taken from https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/327d6ea9ffe66fe2ac64d4ee6373cc6db7845a01